feat(server): start up folder checks (#12401)

server/src/services/storage.service.spec.ts

@@ -1,19 +1,29 @@
+import { SystemMetadataKey } from 'src/enum';
+import { IDatabaseRepository } from 'src/interfaces/database.interface';
 import { ILoggerRepository } from 'src/interfaces/logger.interface';
 import { IStorageRepository } from 'src/interfaces/storage.interface';
+import { ISystemMetadataRepository } from 'src/interfaces/system-metadata.interface';
 import { StorageService } from 'src/services/storage.service';
+import { newDatabaseRepositoryMock } from 'test/repositories/database.repository.mock';
 import { newLoggerRepositoryMock } from 'test/repositories/logger.repository.mock';
 import { newStorageRepositoryMock } from 'test/repositories/storage.repository.mock';
+import { newSystemMetadataRepositoryMock } from 'test/repositories/system-metadata.repository.mock';
 import { Mocked } from 'vitest';
 
 describe(StorageService.name, () => {
   let sut: StorageService;
+  let databaseMock: Mocked<IDatabaseRepository>;
   let storageMock: Mocked<IStorageRepository>;
   let loggerMock: Mocked<ILoggerRepository>;
+  let systemMock: Mocked<ISystemMetadataRepository>;
 
   beforeEach(() => {
+    databaseMock = newDatabaseRepositoryMock();
     storageMock = newStorageRepositoryMock();
     loggerMock = newLoggerRepositoryMock();
-    sut = new StorageService(storageMock, loggerMock);
+    systemMock = newSystemMetadataRepositoryMock();
+
+    sut = new StorageService(databaseMock, storageMock, loggerMock, systemMock);
   });
 
   it('should work', () => {
@@ -21,9 +31,35 @@ describe(StorageService.name, () => {
   });
 
   describe('onBootstrap', () => {
-    it('should create the library folder on initialization', () => {
-      sut.onBootstrap();
+    it('should enable mount folder checking', async () => {
+      systemMock.get.mockResolvedValue(null);
+
+      await expect(sut.onBootstrap()).resolves.toBeUndefined();
+
+      expect(systemMock.set).toHaveBeenCalledWith(SystemMetadataKey.SYSTEM_FLAGS, { mountFiles: true });
+      expect(storageMock.mkdirSync).toHaveBeenCalledWith('upload/encoded-video');
       expect(storageMock.mkdirSync).toHaveBeenCalledWith('upload/library');
+      expect(storageMock.mkdirSync).toHaveBeenCalledWith('upload/profile');
+      expect(storageMock.mkdirSync).toHaveBeenCalledWith('upload/thumbs');
+    });
+
+    it('should throw an error if .immich is missing', async () => {
+      systemMock.get.mockResolvedValue({ mountFiles: true });
+      storageMock.readFile.mockRejectedValue(new Error("ENOENT: no such file or directory, open '/app/.immich'"));
+
+      await expect(sut.onBootstrap()).rejects.toThrow('Failed to validate folder mount');
+
+      expect(storageMock.writeFile).not.toHaveBeenCalled();
+      expect(systemMock.set).not.toHaveBeenCalled();
+    });
+
+    it('should throw an error if .immich is present but read-only', async () => {
+      systemMock.get.mockResolvedValue({ mountFiles: true });
+      storageMock.writeFile.mockRejectedValue(new Error("ENOENT: no such file or directory, open '/app/.immich'"));
+
+      await expect(sut.onBootstrap()).rejects.toThrow('Failed to validate folder mount');
+
+      expect(systemMock.set).not.toHaveBeenCalled();
     });
   });