fix: improve sync backup error indicator (#22527)

* fix: improve sync indicator error

* prefer backup disabled icon before error

---------

Co-authored-by: shenlong-tanwen <139912620+shalong-tanwen@users.noreply.github.com>
Co-authored-by: Alex <alex.tran1502@gmail.com>

mobile/lib/providers/app_life_cycle.provider.dart

@@ -161,7 +161,6 @@ class AppLifeCycleNotifier extends StateNotifier<AppLifeCycleEnum> {
           _resumeBackup(),
         ]);
       } else {
-        _ref.read(driftBackupProvider.notifier).updateError(BackupError.syncFailed);
         await _safeRun(backgroundManager.hashAssets(), "hashAssets");
       }
 

mobile/lib/providers/background_sync.provider.dart

@@ -1,12 +1,21 @@
 import 'package:hooks_riverpod/hooks_riverpod.dart';
 import 'package:immich_mobile/domain/utils/background_sync.dart';
+import 'package:immich_mobile/providers/backup/drift_backup.provider.dart';
 import 'package:immich_mobile/providers/sync_status.provider.dart';
 
 final backgroundSyncProvider = Provider<BackgroundSyncManager>((ref) {
   final syncStatusNotifier = ref.read(syncStatusProvider.notifier);
+  final backupProvider = ref.read(driftBackupProvider.notifier);
+
   final manager = BackgroundSyncManager(
-    onRemoteSyncStart: syncStatusNotifier.startRemoteSync,
-    onRemoteSyncComplete: syncStatusNotifier.completeRemoteSync,
+    onRemoteSyncStart: () {
+      syncStatusNotifier.startRemoteSync();
+      backupProvider.updateError(BackupError.none);
+    },
+    onRemoteSyncComplete: (isSuccess) {
+      syncStatusNotifier.completeRemoteSync();
+      backupProvider.updateError(isSuccess == true ? BackupError.none : BackupError.syncFailed);
+    },
     onRemoteSyncError: syncStatusNotifier.errorRemoteSync,
     onLocalSyncStart: syncStatusNotifier.startLocalSync,
     onLocalSyncComplete: syncStatusNotifier.completeLocalSync,