feat(server): make is favorite optional on asset upload (#4865)

* feat(server): make isFavorite optional

* chore: open api

* chore: e2e

server/immich-openapi-specs.json

@@ -6655,8 +6655,7 @@
           "deviceAssetId",
           "deviceId",
           "fileCreatedAt",
-          "fileModifiedAt",
-          "isFavorite"
+          "fileModifiedAt"
         ],
         "type": "object"
       },
@@ -7143,8 +7142,7 @@
           "deviceAssetId",
           "deviceId",
           "fileCreatedAt",
-          "fileModifiedAt",
-          "isFavorite"
+          "fileModifiedAt"
         ],
         "type": "object"
       },

server/src/immich/api-v1/asset/dto/create-asset.dto.ts

@@ -22,9 +22,10 @@ export class CreateAssetBase {
   @Type(() => Date)
   fileModifiedAt!: Date;
 
+  @Optional()
   @IsBoolean()
   @Transform(toBoolean)
-  isFavorite!: boolean;
+  isFavorite?: boolean;
 
   @Optional()
   @IsBoolean()

server/test/e2e/asset.e2e-spec.ts

@@ -146,7 +146,6 @@ describe(`${AssetController.name} (e2e)`, () => {
       { should: 'require `deviceId`', dto: { ...makeUploadDto({ omit: 'deviceId' }) } },
       { should: 'require `fileCreatedAt`', dto: { ...makeUploadDto({ omit: 'fileCreatedAt' }) } },
       { should: 'require `fileModifiedAt`', dto: { ...makeUploadDto({ omit: 'fileModifiedAt' }) } },
-      { should: 'require `isFavorite`', dto: { ...makeUploadDto({ omit: 'isFavorite' }) } },
       { should: 'require `duration`', dto: { ...makeUploadDto({ omit: 'duration' }) } },
       { should: 'throw if `isFavorite` is not a boolean', dto: { ...makeUploadDto(), isFavorite: 'not-a-boolean' } },
       { should: 'throw if `isVisible` is not a boolean', dto: { ...makeUploadDto(), isVisible: 'not-a-boolean' } },