refactor: domain repositories (#4403)

server/src/domain/person/index.ts

@@ -1,3 +1,2 @@
 export * from './person.dto';
-export * from './person.repository';
 export * from './person.service';

server/src/domain/person/person.repository.ts

@@ -1,39 +0,0 @@
-import { AssetEntity, AssetFaceEntity, PersonEntity } from '@app/infra/entities';
-export const IPersonRepository = 'IPersonRepository';
-
-export interface PersonSearchOptions {
-  minimumFaceCount: number;
-  withHidden: boolean;
-}
-
-export interface AssetFaceId {
-  assetId: string;
-  personId: string;
-}
-
-export interface UpdateFacesData {
-  oldPersonId: string;
-  newPersonId: string;
-}
-
-export interface IPersonRepository {
-  getAll(): Promise<PersonEntity[]>;
-  getAllWithoutThumbnail(): Promise<PersonEntity[]>;
-  getAllForUser(userId: string, options: PersonSearchOptions): Promise<PersonEntity[]>;
-  getAllWithoutFaces(): Promise<PersonEntity[]>;
-  getById(personId: string): Promise<PersonEntity | null>;
-
-  getAssets(personId: string): Promise<AssetEntity[]>;
-  prepareReassignFaces(data: UpdateFacesData): Promise<string[]>;
-  reassignFaces(data: UpdateFacesData): Promise<number>;
-
-  create(entity: Partial<PersonEntity>): Promise<PersonEntity>;
-  update(entity: Partial<PersonEntity>): Promise<PersonEntity>;
-  delete(entity: PersonEntity): Promise<PersonEntity | null>;
-  deleteAll(): Promise<number>;
-
-  getAllFaces(): Promise<AssetFaceEntity[]>;
-  getFacesByIds(ids: AssetFaceId[]): Promise<AssetFaceEntity[]>;
-  getRandomFace(personId: string): Promise<AssetFaceEntity | null>;
-  createFace(entity: Partial<AssetFaceEntity>): Promise<AssetFaceEntity>;
-}

server/src/domain/person/person.service.spec.ts

@@ -16,15 +16,20 @@ import {
   newSystemConfigRepositoryMock,
   personStub,
 } from '@test';
-import { BulkIdErrorReason, IAssetRepository, WithoutProperty } from '../asset';
-import { IJobRepository, JobName } from '../job';
-import { IMediaRepository } from '../media';
-import { ISearchRepository } from '../search';
-import { IMachineLearningRepository } from '../smart-info';
-import { IStorageRepository } from '../storage';
-import { ISystemConfigRepository } from '../system-config';
+import { BulkIdErrorReason } from '../asset';
+import { JobName } from '../job';
+import {
+  IAssetRepository,
+  IJobRepository,
+  IMachineLearningRepository,
+  IMediaRepository,
+  IPersonRepository,
+  ISearchRepository,
+  IStorageRepository,
+  ISystemConfigRepository,
+  WithoutProperty,
+} from '../repositories';
 import { PersonResponseDto } from './person.dto';
-import { IPersonRepository } from './person.repository';
 import { PersonService } from './person.service';
 
 const responseDto: PersonResponseDto = {

server/src/domain/person/person.service.ts

@@ -1,23 +1,30 @@
 import { PersonEntity } from '@app/infra/entities';
 import { BadRequestException, Inject, Injectable, Logger, NotFoundException } from '@nestjs/common';
-import { AccessCore, IAccessRepository, Permission } from '../access';
-import {
-  AssetResponseDto,
-  BulkIdErrorReason,
-  BulkIdResponseDto,
-  IAssetRepository,
-  WithoutProperty,
-  mapAsset,
-} from '../asset';
+import { AccessCore, Permission } from '../access';
+import { AssetResponseDto, BulkIdErrorReason, BulkIdResponseDto, mapAsset } from '../asset';
 import { AuthUserDto } from '../auth';
 import { mimeTypes } from '../domain.constant';
 import { usePagination } from '../domain.util';
-import { IBaseJob, IEntityJob, IJobRepository, JOBS_ASSET_PAGINATION_SIZE, JobName } from '../job';
-import { CropOptions, FACE_THUMBNAIL_SIZE, IMediaRepository } from '../media';
-import { ISearchRepository } from '../search';
-import { IMachineLearningRepository } from '../smart-info';
-import { IStorageRepository, ImmichReadStream, StorageCore, StorageFolder } from '../storage';
-import { ISystemConfigRepository, SystemConfigCore } from '../system-config';
+import { IBaseJob, IEntityJob, JOBS_ASSET_PAGINATION_SIZE, JobName } from '../job';
+import { FACE_THUMBNAIL_SIZE } from '../media';
+import {
+  AssetFaceId,
+  CropOptions,
+  IAccessRepository,
+  IAssetRepository,
+  IJobRepository,
+  IMachineLearningRepository,
+  IMediaRepository,
+  IPersonRepository,
+  ISearchRepository,
+  IStorageRepository,
+  ISystemConfigRepository,
+  ImmichReadStream,
+  UpdateFacesData,
+  WithoutProperty,
+} from '../repositories';
+import { StorageCore, StorageFolder } from '../storage';
+import { SystemConfigCore } from '../system-config';
 import {
   MergePersonDto,
   PeopleResponseDto,
@@ -27,7 +34,6 @@ import {
   PersonUpdateDto,
   mapPerson,
 } from './person.dto';
-import { AssetFaceId, IPersonRepository, UpdateFacesData } from './person.repository';
 
 @Injectable()
 export class PersonService {