fix(server): regenerate missing person thumbnails (#3970)

* Regenerate missing person thumbnails

* Check for empty string instead of zero length

* Remember asset used as person face

* Define entity relation between person and asset via faceAssetId

* Typo

* Fix entity relation

* Tests

* Tests

* Fix code formatting

* Fix import path

* Fix migration

* format

* Fix entity and migration

* Linting

* Remove unneeded cast

* Conventions

* Simplify queries

* Simplify queries

* Remove unneeded typings from entity

* Remove unneeded cast

---------

Co-authored-by: Alex <alex.tran1502@gmail.com>

server/src/domain/person/person.repository.ts

@@ -13,7 +13,9 @@ export interface UpdateFacesData {
 }
 
 export interface IPersonRepository {
-  getAll(userId: string, options: PersonSearchOptions): Promise<PersonEntity[]>;
+  getAll(): Promise<PersonEntity[]>;
+  getAllWithoutThumbnail(): Promise<PersonEntity[]>;
+  getAllForUser(userId: string, options: PersonSearchOptions): Promise<PersonEntity[]>;
   getAllWithoutFaces(): Promise<PersonEntity[]>;
   getById(userId: string, personId: string): Promise<PersonEntity | null>;
 
@@ -27,4 +29,5 @@ export interface IPersonRepository {
   deleteAll(): Promise<number>;
 
   getFaceById(payload: AssetFaceId): Promise<AssetFaceEntity | null>;
+  getRandomFace(personId: string): Promise<AssetFaceEntity | null>;
 }

server/src/domain/person/person.service.spec.ts

@@ -42,25 +42,31 @@ describe(PersonService.name, () => {
 
   describe('getAll', () => {
     it('should get all people with thumbnails', async () => {
-      personMock.getAll.mockResolvedValue([personStub.withName, personStub.noThumbnail]);
+      personMock.getAllForUser.mockResolvedValue([personStub.withName, personStub.noThumbnail]);
       await expect(sut.getAll(authStub.admin, { withHidden: undefined })).resolves.toEqual({
         total: 1,
         visible: 1,
         people: [responseDto],
       });
-      expect(personMock.getAll).toHaveBeenCalledWith(authStub.admin.id, { minimumFaceCount: 1, withHidden: false });
+      expect(personMock.getAllForUser).toHaveBeenCalledWith(authStub.admin.id, {
+        minimumFaceCount: 1,
+        withHidden: false,
+      });
     });
     it('should get all visible people with thumbnails', async () => {
-      personMock.getAll.mockResolvedValue([personStub.withName, personStub.hidden]);
+      personMock.getAllForUser.mockResolvedValue([personStub.withName, personStub.hidden]);
       await expect(sut.getAll(authStub.admin, { withHidden: false })).resolves.toEqual({
         total: 2,
         visible: 1,
         people: [responseDto],
       });
-      expect(personMock.getAll).toHaveBeenCalledWith(authStub.admin.id, { minimumFaceCount: 1, withHidden: false });
+      expect(personMock.getAllForUser).toHaveBeenCalledWith(authStub.admin.id, {
+        minimumFaceCount: 1,
+        withHidden: false,
+      });
     });
     it('should get all hidden and visible people with thumbnails', async () => {
-      personMock.getAll.mockResolvedValue([personStub.withName, personStub.hidden]);
+      personMock.getAllForUser.mockResolvedValue([personStub.withName, personStub.hidden]);
       await expect(sut.getAll(authStub.admin, { withHidden: true })).resolves.toEqual({
         total: 2,
         visible: 1,
@@ -75,7 +81,10 @@ describe(PersonService.name, () => {
           },
         ],
       });
-      expect(personMock.getAll).toHaveBeenCalledWith(authStub.admin.id, { minimumFaceCount: 1, withHidden: true });
+      expect(personMock.getAllForUser).toHaveBeenCalledWith(authStub.admin.id, {
+        minimumFaceCount: 1,
+        withHidden: true,
+      });
     });
   });
 

server/src/domain/person/person.service.ts

@@ -26,7 +26,7 @@ export class PersonService {
   ) {}
 
   async getAll(authUser: AuthUserDto, dto: PersonSearchDto): Promise<PeopleResponseDto> {
-    const people = await this.repository.getAll(authUser.id, {
+    const people = await this.repository.getAllForUser(authUser.id, {
       minimumFaceCount: 1,
       withHidden: dto.withHidden || false,
     });