chore: code review changes

i18n/en.json

@@ -1034,6 +1034,7 @@
   },
   "exif": "Exif",
   "exif_bottom_sheet_description": "Add Description...",
+  "exif_bottom_sheet_no_description": "No description",
   "exif_bottom_sheet_description_error": "Error updating description",
   "exif_bottom_sheet_details": "DETAILS",
   "exif_bottom_sheet_location": "LOCATION",

mobile/lib/presentation/pages/drift_remote_album.page.dart

@@ -173,7 +173,7 @@ class _RemoteAlbumPageState extends ConsumerState<RemoteAlbumPage> {
     final user = ref.watch(currentUserProvider);
     final isOwner = user != null ? user.id == _album.ownerId : false;
     final canAddPhotos =
-        await ref.read(remoteAlbumUserRoleProvider((_album.id, user!.id)).future) == AlbumUserRole.editor;
+        await ref.read(remoteAlbumServiceProvider).getUserRole(_album.id, user?.id ?? '') == AlbumUserRole.editor;
 
     showModalBottomSheet(
       context: context,

mobile/lib/presentation/widgets/asset_viewer/bottom_sheet.widget.dart

@@ -151,7 +151,7 @@ class _AssetDetailBottomSheet extends ConsumerWidget {
           trailing: asset.hasRemote && isOwner ? const Icon(Icons.edit, size: 18) : null,
           onTap: asset.hasRemote && isOwner ? () async => await _editDateTime(context, ref) : null,
         ),
-        if (exifInfo != null && isOwner) _SheetAssetDescription(exif: exifInfo),
+        if (exifInfo != null) _SheetAssetDescription(exif: exifInfo, isEditable: isOwner),
         const SheetPeopleDetails(),
         const SheetLocationDetails(),
         // Details header
@@ -265,8 +265,9 @@ class _SheetTile extends ConsumerWidget {
 
 class _SheetAssetDescription extends ConsumerStatefulWidget {
   final ExifInfo exif;
+  final bool isEditable;
 
-  const _SheetAssetDescription({required this.exif});
+  const _SheetAssetDescription({required this.exif, this.isEditable = true, super.key});
 
   @override
   ConsumerState<_SheetAssetDescription> createState() => _SheetAssetDescriptionState();
@@ -312,19 +313,24 @@ class _SheetAssetDescriptionState extends ConsumerState<_SheetAssetDescription>
 
     // Update controller text when EXIF data changes
     final currentDescription = currentExifInfo?.description ?? '';
+    final hintText = (widget.isEditable ? 'exif_bottom_sheet_description' : 'exif_bottom_sheet_no_description').t(
+      context: context,
+    );
     if (_controller.text != currentDescription && !_descriptionFocus.hasFocus) {
       _controller.text = currentDescription;
     }
 
     return Padding(
       padding: const EdgeInsets.symmetric(horizontal: 16.0, vertical: 8),
+      child: IgnorePointer(
+        ignoring: !widget.isEditable,
         child: TextField(
           controller: _controller,
           keyboardType: TextInputType.multiline,
           focusNode: _descriptionFocus,
           maxLines: null, // makes it grow as text is added
           decoration: InputDecoration(
-          hintText: 'exif_bottom_sheet_description'.t(context: context),
+            hintText: hintText,
             border: InputBorder.none,
             enabledBorder: InputBorder.none,
             focusedBorder: InputBorder.none,
@@ -334,6 +340,7 @@ class _SheetAssetDescriptionState extends ConsumerState<_SheetAssetDescription>
           ),
           onTapOutside: (_) => saveDescription(currentExifInfo?.description),
         ),
+      ),
     );
   }
 }

mobile/lib/presentation/widgets/bottom_sheet/remote_album_bottom_sheet.widget.dart

@@ -95,20 +95,23 @@ class _RemoteAlbumBottomSheetState extends ConsumerState<RemoteAlbumBottomSheet>
         const ShareActionButton(source: ActionSource.timeline),
         if (multiselect.hasRemote) ...[
           const ShareLinkActionButton(source: ActionSource.timeline),
-          if (ownsAlbum) const ArchiveActionButton(source: ActionSource.timeline),
+
-          if (ownsAlbum) const FavoriteActionButton(source: ActionSource.timeline),
+          if (ownsAlbum) ...[
+            const ArchiveActionButton(source: ActionSource.timeline),
+            const FavoriteActionButton(source: ActionSource.timeline),
+          ],
           const DownloadActionButton(source: ActionSource.timeline),
-          if (ownsAlbum)
+          if (ownsAlbum) ...[
             isTrashEnable
                 ? const TrashActionButton(source: ActionSource.timeline)
                 : const DeletePermanentActionButton(source: ActionSource.timeline),
-          if (ownsAlbum) const EditDateTimeActionButton(source: ActionSource.timeline),
+            const EditDateTimeActionButton(source: ActionSource.timeline),
-          if (ownsAlbum) const EditLocationActionButton(source: ActionSource.timeline),
+            const EditLocationActionButton(source: ActionSource.timeline),
-          if (ownsAlbum) const MoveToLockFolderActionButton(source: ActionSource.timeline),
+            const MoveToLockFolderActionButton(source: ActionSource.timeline),
-          if (multiselect.selectedAssets.length > 1 && ownsAlbum)
+            if (multiselect.selectedAssets.length > 1) const StackActionButton(source: ActionSource.timeline),
-            const StackActionButton(source: ActionSource.timeline),
             if (multiselect.hasStacked) const UnStackActionButton(source: ActionSource.timeline),
           ],
+        ],
         if (multiselect.hasLocal) ...[
           const DeleteLocalActionButton(source: ActionSource.timeline),
           const UploadActionButton(source: ActionSource.timeline),

mobile/lib/providers/infrastructure/remote_album.provider.dart

@@ -178,13 +178,3 @@ final remoteAlbumSharedUsersProvider = FutureProvider.autoDispose.family<List<Us
   final service = ref.watch(remoteAlbumServiceProvider);
   return service.getSharedUsers(albumId);
 });
-
-final remoteAlbumUserRoleProvider = FutureProvider.autoDispose.family<AlbumUserRole?, (String, String)>((
-  ref,
-  data,
-) async {
-  final link = ref.keepAlive();
-  ref.onDispose(() => link.close());
-  final service = ref.watch(remoteAlbumServiceProvider);
-  return service.getUserRole(data.$1, data.$2);
-});