chore: cleanup e2e (#5051)

server/test/e2e/shared-link.e2e-spec.ts

@@ -3,23 +3,11 @@ import { SharedLinkController } from '@app/immich';
 import { SharedLinkType } from '@app/infra/entities';
 import { INestApplication } from '@nestjs/common';
 import { api } from '@test/api';
-import { errorStub, uuidStub } from '@test/fixtures';
+import { errorStub, userDto, uuidStub } from '@test/fixtures';
 import { testApp } from '@test/test-utils';
 import { DateTime } from 'luxon';
 import request from 'supertest';
 
-const user1Dto = {
-  email: 'user1@immich.app',
-  password: 'Password123',
-  name: 'User 1',
-};
-
-const user2Dto = {
-  email: 'user2@immich.app',
-  password: 'Password123',
-  name: 'User 2',
-};
-
 const today = new Date();
 
 describe(`${SharedLinkController.name} (e2e)`, () => {
@@ -46,13 +34,13 @@ describe(`${SharedLinkController.name} (e2e)`, () => {
     admin = await api.authApi.adminLogin(server);
 
     await Promise.all([
-      api.userApi.create(server, admin.accessToken, user1Dto),
-      api.userApi.create(server, admin.accessToken, user2Dto),
+      api.userApi.create(server, admin.accessToken, userDto.user1),
+      api.userApi.create(server, admin.accessToken, userDto.user2),
     ]);
 
     [user1, user2] = await Promise.all([
-      api.authApi.login(server, { email: user1Dto.email, password: user1Dto.password }),
-      api.authApi.login(server, { email: user2Dto.email, password: user2Dto.password }),
+      api.authApi.login(server, userDto.user1),
+      api.authApi.login(server, userDto.user2),
     ]);
 
     const asset = await api.assetApi.create(server, user1.accessToken, {