refactor: DCM - const border radius, constructor & switch expressions (#19515)

* enable border radius, switch exp, const constructor * regenerate provider * more formatting --------- Co-authored-by: shenlong-tanwen <139912620+shalong-tanwen@users.noreply.github.com>
2025-06-25 13:06:24 +05:30
parent 05064f87f0
commit 5b0575b956
130 changed files with 338 additions and 264 deletions
@@ -18,7 +18,7 @@ final albumRepositoryProvider =
    Provider((ref) => AlbumRepository(ref.watch(dbProvider)));

 class AlbumRepository extends DatabaseRepository {
-  AlbumRepository(super.db);
+  const AlbumRepository(super.db);

  Future<int> count({bool? local}) {
    final baseQuery = db.albums.where();
@@ -3,7 +3,7 @@ import 'package:immich_mobile/constants/errors.dart';
 abstract class ApiRepository {
  Future<T> checkNull<T>(Future<T?> future) async {
    final response = await future;
-    if (response == null) throw NoResponseDtoError();
+    if (response == null) throw const NoResponseDtoError();
    return response;
  }
 }
@@ -15,7 +15,7 @@ final assetRepositoryProvider =
    Provider((ref) => AssetRepository(ref.watch(dbProvider)));

 class AssetRepository extends DatabaseRepository {
-  AssetRepository(super.db);
+  const AssetRepository(super.db);

  Future<List<Asset>> getByAlbum(
    Album album, {
@@ -56,18 +56,12 @@ class AssetApiRepository extends ApiRepository {
    );
  }

-  _mapVisibility(AssetVisibilityEnum visibility) {
-    switch (visibility) {
-      case AssetVisibilityEnum.timeline:
-        return AssetVisibility.timeline;
-      case AssetVisibilityEnum.hidden:
-        return AssetVisibility.hidden;
-      case AssetVisibilityEnum.locked:
-        return AssetVisibility.locked;
-      case AssetVisibilityEnum.archive:
-        return AssetVisibility.archive;
-    }
-  }
+  _mapVisibility(AssetVisibilityEnum visibility) => switch (visibility) {
+        AssetVisibilityEnum.timeline => AssetVisibility.timeline,
+        AssetVisibilityEnum.hidden => AssetVisibility.hidden,
+        AssetVisibilityEnum.locked => AssetVisibility.locked,
+        AssetVisibilityEnum.archive => AssetVisibility.archive,
+      };

  Future<String?> getAssetMIMEType(String assetId) async {
    final response = await checkNull(_api.getAssetInfo(assetId));
@@ -6,9 +6,11 @@ import 'package:immich_mobile/entities/store.entity.dart';
 import 'package:immich_mobile/utils/hash.dart';
 import 'package:photo_manager/photo_manager.dart' hide AssetType;

-final assetMediaRepositoryProvider = Provider((ref) => AssetMediaRepository());
+final assetMediaRepositoryProvider =
+    Provider((ref) => const AssetMediaRepository());

 class AssetMediaRepository {
+  const AssetMediaRepository();
  Future<List<String>> deleteAll(List<String> ids) =>
      PhotoManager.editor.deleteWithIds(ids);

@@ -22,7 +22,7 @@ final authRepositoryProvider = Provider<AuthRepository>(
 class AuthRepository extends DatabaseRepository {
  final Drift _drift;

-  AuthRepository(super.db, this._drift);
+  const AuthRepository(super.db, this._drift);

  Future<void> clearLocalData() {
    return db.writeTxn(() {
@@ -10,7 +10,7 @@ final backupAlbumRepositoryProvider =
    Provider((ref) => BackupAlbumRepository(ref.watch(dbProvider)));

 class BackupAlbumRepository extends DatabaseRepository {
-  BackupAlbumRepository(super.db);
+  const BackupAlbumRepository(super.db);

  Future<List<BackupAlbum>> getAll({BackupAlbumSort? sort}) {
    final baseQuery = db.backupAlbums.where();
@@ -9,7 +9,7 @@ final biometricRepositoryProvider =
 class BiometricRepository {
  final LocalAuthentication _localAuth;

-  BiometricRepository(this._localAuth);
+  const BiometricRepository(this._localAuth);

  Future<BiometricStatus> getStatus() async {
    final bool canAuthenticateWithBiometrics =
@@ -7,7 +7,7 @@ const Symbol _zoneTxn = #zoneTxn;

 abstract class DatabaseRepository implements IDatabaseRepository {
  final Isar db;
-  DatabaseRepository(this.db);
+  const DatabaseRepository(this.db);

  bool get inTxn => Zone.current[_zoneTxn] != null;

@@ -8,7 +8,7 @@ final etagRepositoryProvider =
    Provider((ref) => ETagRepository(ref.watch(dbProvider)));

 class ETagRepository extends DatabaseRepository {
-  ETagRepository(super.db);
+  const ETagRepository(super.db);

  Future<List<String>> getAllIds() => db.eTags.where().idProperty().findAll();

@@ -6,9 +6,11 @@ import 'package:immich_mobile/entities/asset.entity.dart';
 import 'package:immich_mobile/repositories/asset_media.repository.dart';
 import 'package:photo_manager/photo_manager.dart' hide AssetType;

-final fileMediaRepositoryProvider = Provider((ref) => FileMediaRepository());
+final fileMediaRepositoryProvider =
+    Provider((ref) => const FileMediaRepository());

 class FileMediaRepository {
+  const FileMediaRepository();
  Future<Asset?> saveImage(
    Uint8List data, {
    required String title,
@@ -7,7 +7,7 @@ final localFilesManagerRepositoryProvider = Provider(
 );

 class LocalFilesManagerRepository {
-  LocalFilesManagerRepository(this._service);
+  const LocalFilesManagerRepository(this._service);

  final LocalFilesManagerService _service;

@@ -12,7 +12,7 @@ final networkRepositoryProvider = Provider((_) {
 class NetworkRepository {
  final NetworkInfo _networkInfo;

-  NetworkRepository(this._networkInfo);
+  const NetworkRepository(this._networkInfo);

  Future<String?> getWifiName() {
    if (Platform.isAndroid) {
@@ -11,7 +11,7 @@ final partnerRepositoryProvider = Provider(
 );

 class PartnerRepository extends DatabaseRepository {
-  PartnerRepository(super.db);
+  const PartnerRepository(super.db);

  Future<List<UserDto>> getSharedBy() async {
    return (await db.users
@@ -2,11 +2,11 @@ import 'package:hooks_riverpod/hooks_riverpod.dart';
 import 'package:permission_handler/permission_handler.dart';

 final permissionRepositoryProvider = Provider((_) {
-  return PermissionRepository();
+  return const PermissionRepository();
 });

 class PermissionRepository implements IPermissionRepository {
-  PermissionRepository();
+  const PermissionRepository();

  @override
  Future<bool> hasLocationWhenInUsePermission() {
@@ -2,12 +2,12 @@ import 'package:flutter_secure_storage/flutter_secure_storage.dart';
 import 'package:hooks_riverpod/hooks_riverpod.dart';

 final secureStorageRepositoryProvider =
-    Provider((ref) => SecureStorageRepository(const FlutterSecureStorage()));
+    Provider((ref) => const SecureStorageRepository(FlutterSecureStorage()));

 class SecureStorageRepository {
  final FlutterSecureStorage _secureStorage;

-  SecureStorageRepository(this._secureStorage);
+  const SecureStorageRepository(this._secureStorage);

  Future<String?> read(String key) {
    return _secureStorage.read(key: key);
@@ -13,7 +13,7 @@ final timelineRepositoryProvider =
    Provider((ref) => TimelineRepository(ref.watch(dbProvider)));

 class TimelineRepository extends DatabaseRepository {
-  TimelineRepository(super.db);
+  const TimelineRepository(super.db);

  Future<List<String>> getTimelineUserIds(String id) {
    return db.users
@@ -1,10 +1,10 @@
 import 'package:home_widget/home_widget.dart';
 import 'package:hooks_riverpod/hooks_riverpod.dart';

-final widgetRepositoryProvider = Provider((_) => WidgetRepository());
+final widgetRepositoryProvider = Provider((_) => const WidgetRepository());

 class WidgetRepository {
-  WidgetRepository();
+  const WidgetRepository();

  Future<void> saveData(String key, String value) async {
    await HomeWidget.saveWidgetData<String>(key, value);