chore(server): eslint await-thenable (#7545)

* await-thenable

* fix library watchers

* moar eslint

* fix test

* fix typo

* try to remove check void return

* fix checksVoidReturn

* move to domain utils

* remove eslint ignores

* chore: cleanup types

* chore: use logger

* fix: e2e

---------

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>

server/src/domain/system-config/system-config.service.spec.ts

@@ -148,7 +148,7 @@ describe(SystemConfigService.name, () => {
   let communicationMock: jest.Mocked<ICommunicationRepository>;
   let smartInfoMock: jest.Mocked<ISearchRepository>;
 
-  beforeEach(async () => {
+  beforeEach(() => {
     delete process.env.IMMICH_CONFIG_FILE;
     configMock = newSystemConfigRepositoryMock();
     communicationMock = newCommunicationRepositoryMock();

server/src/domain/system-config/system-config.service.ts

@@ -118,7 +118,7 @@ export class SystemConfigService {
     await this.core.refreshConfig();
   }
 
-  private async setLogLevel({ logging }: SystemConfig) {
+  private setLogLevel({ logging }: SystemConfig) {
     const envLevel = this.getEnvLogLevel();
     const configLevel = logging.enabled ? logging.level : false;
     const level = envLevel ?? configLevel;
@@ -130,7 +130,7 @@ export class SystemConfigService {
     return process.env.LOG_LEVEL as LogLevel;
   }
 
-  private async validateConfig(newConfig: SystemConfig, oldConfig: SystemConfig) {
+  private validateConfig(newConfig: SystemConfig, oldConfig: SystemConfig) {
     if (!_.isEqual(instanceToPlain(newConfig.logging), oldConfig.logging) && this.getEnvLogLevel()) {
       throw new Error('Logging cannot be changed while the environment variable LOG_LEVEL is set.');
     }