chore(server): improve e2e test speed (#5026)

* feat: improve shared link (41s to 8s)

* feat: improve activity (18s to 8s)

* feat: improve partner (20s to 10s)

* feat: improve server-info (10s to 6s)

* feat: improve system-config

* fix: e2e

* chore: linting

server/test/e2e/partner.e2e-spec.ts

@@ -1,6 +1,5 @@
-import { IPartnerRepository, LoginResponseDto, PartnerDirection } from '@app/domain';
+import { LoginResponseDto, PartnerDirection } from '@app/domain';
 import { PartnerController } from '@app/immich';
-import { INestApplication } from '@nestjs/common';
 import { api } from '@test/api';
 import { db } from '@test/db';
 import { errorStub } from '@test/fixtures';
@@ -19,41 +18,47 @@ const user2Dto = {
   name: 'User 2',
 };
 
+const user3Dto = {
+  email: 'user3@immich.app',
+  password: 'Password123',
+  name: 'User 3',
+};
+
 describe(`${PartnerController.name} (e2e)`, () => {
-  let app: INestApplication;
   let server: any;
-  let loginResponse: LoginResponseDto;
-  let accessToken: string;
-  let repository: IPartnerRepository;
   let user1: LoginResponseDto;
   let user2: LoginResponseDto;
+  let user3: LoginResponseDto;
 
   beforeAll(async () => {
-    [server, app] = await testApp.create();
-    repository = app.get<IPartnerRepository>(IPartnerRepository);
+    [server] = await testApp.create();
+
+    await db.reset();
+    await api.authApi.adminSignUp(server);
+    const admin = await api.authApi.adminLogin(server);
+
+    await Promise.all([
+      api.userApi.create(server, admin.accessToken, user1Dto),
+      api.userApi.create(server, admin.accessToken, user2Dto),
+      api.userApi.create(server, admin.accessToken, user3Dto),
+    ]);
+
+    [user1, user2, user3] = await Promise.all([
+      api.authApi.login(server, { email: user1Dto.email, password: user1Dto.password }),
+      api.authApi.login(server, { email: user2Dto.email, password: user2Dto.password }),
+      api.authApi.login(server, { email: user3Dto.email, password: user3Dto.password }),
+    ]);
+
+    await Promise.all([
+      api.partnerApi.create(server, user1.accessToken, user2.userId),
+      api.partnerApi.create(server, user2.accessToken, user1.userId),
+    ]);
   });
 
   afterAll(async () => {
     await testApp.teardown();
   });
 
-  beforeEach(async () => {
-    await db.reset();
-    await api.authApi.adminSignUp(server);
-    loginResponse = await api.authApi.adminLogin(server);
-    accessToken = loginResponse.accessToken;
-
-    await Promise.all([
-      api.userApi.create(server, accessToken, user1Dto),
-      api.userApi.create(server, accessToken, user2Dto),
-    ]);
-
-    [user1, user2] = await Promise.all([
-      api.authApi.login(server, { email: user1Dto.email, password: user1Dto.password }),
-      api.authApi.login(server, { email: user2Dto.email, password: user2Dto.password }),
-    ]);
-  });
-
   describe('GET /partner', () => {
     it('should require authentication', async () => {
       const { status, body } = await request(server).get('/partner');
@@ -63,7 +68,6 @@ describe(`${PartnerController.name} (e2e)`, () => {
     });
 
     it('should get all partners shared by user', async () => {
-      await repository.create({ sharedById: user1.userId, sharedWithId: user2.userId });
       const { status, body } = await request(server)
         .get('/partner')
         .set('Authorization', `Bearer ${user1.accessToken}`)
@@ -74,7 +78,6 @@ describe(`${PartnerController.name} (e2e)`, () => {
     });
 
     it('should get all partners that share with user', async () => {
-      await repository.create({ sharedById: user2.userId, sharedWithId: user1.userId });
       const { status, body } = await request(server)
         .get('/partner')
         .set('Authorization', `Bearer ${user1.accessToken}`)
@@ -87,7 +90,7 @@ describe(`${PartnerController.name} (e2e)`, () => {
 
   describe('POST /partner/:id', () => {
     it('should require authentication', async () => {
-      const { status, body } = await request(server).post(`/partner/${user2.userId}`);
+      const { status, body } = await request(server).post(`/partner/${user3.userId}`);
 
       expect(status).toBe(401);
       expect(body).toEqual(errorStub.unauthorized);
@@ -95,15 +98,14 @@ describe(`${PartnerController.name} (e2e)`, () => {
 
     it('should share with new partner', async () => {
       const { status, body } = await request(server)
-        .post(`/partner/${user2.userId}`)
+        .post(`/partner/${user3.userId}`)
         .set('Authorization', `Bearer ${user1.accessToken}`);
 
       expect(status).toBe(201);
-      expect(body).toEqual(expect.objectContaining({ id: user2.userId }));
+      expect(body).toEqual(expect.objectContaining({ id: user3.userId }));
     });
 
     it('should not share with new partner if already sharing with this partner', async () => {
-      await repository.create({ sharedById: user1.userId, sharedWithId: user2.userId });
       const { status, body } = await request(server)
         .post(`/partner/${user2.userId}`)
         .set('Authorization', `Bearer ${user1.accessToken}`);
@@ -122,7 +124,6 @@ describe(`${PartnerController.name} (e2e)`, () => {
     });
 
     it('should update partner', async () => {
-      await repository.create({ sharedById: user2.userId, sharedWithId: user1.userId });
       const { status, body } = await request(server)
         .put(`/partner/${user2.userId}`)
         .set('Authorization', `Bearer ${user1.accessToken}`)
@@ -135,16 +136,15 @@ describe(`${PartnerController.name} (e2e)`, () => {
 
   describe('DELETE /partner/:id', () => {
     it('should require authentication', async () => {
-      const { status, body } = await request(server).delete(`/partner/${user2.userId}`);
+      const { status, body } = await request(server).delete(`/partner/${user3.userId}`);
 
       expect(status).toBe(401);
       expect(body).toEqual(errorStub.unauthorized);
     });
 
     it('should delete partner', async () => {
-      await repository.create({ sharedById: user1.userId, sharedWithId: user2.userId });
       const { status } = await request(server)
-        .delete(`/partner/${user2.userId}`)
+        .delete(`/partner/${user3.userId}`)
         .set('Authorization', `Bearer ${user1.accessToken}`);
 
       expect(status).toBe(200);
@@ -152,7 +152,7 @@ describe(`${PartnerController.name} (e2e)`, () => {
 
     it('should throw a bad request if partner not found', async () => {
       const { status, body } = await request(server)
-        .delete(`/partner/${user2.userId}`)
+        .delete(`/partner/${user3.userId}`)
         .set('Authorization', `Bearer ${user1.accessToken}`);
 
       expect(status).toBe(400);