fix(server): delete large album (#11042)

fix: large album asset operations
This commit is contained in:
Jason Rasmussen
2024-07-17 07:43:35 -04:00
committed by GitHub
parent f0d1dbccf4
commit 66fae76af2
5 changed files with 52 additions and 22 deletions
+2 -3
View File
@@ -302,8 +302,7 @@ describe(AlbumService.name, () => {
describe('delete', () => {
it('should throw an error for an album not found', async () => {
accessMock.album.checkOwnerAccess.mockResolvedValue(new Set([albumStub.sharedWithAdmin.id]));
albumMock.getById.mockResolvedValue(null);
accessMock.album.checkOwnerAccess.mockResolvedValue(new Set());
await expect(sut.delete(authStub.admin, albumStub.sharedWithAdmin.id)).rejects.toBeInstanceOf(
BadRequestException,
@@ -329,7 +328,7 @@ describe(AlbumService.name, () => {
await sut.delete(authStub.admin, albumStub.empty.id);
expect(albumMock.delete).toHaveBeenCalledTimes(1);
expect(albumMock.delete).toHaveBeenCalledWith(albumStub.empty);
expect(albumMock.delete).toHaveBeenCalledWith(albumStub.empty.id);
});
});
+1 -4
View File
@@ -165,10 +165,7 @@ export class AlbumService {
async delete(auth: AuthDto, id: string): Promise<void> {
await this.access.requirePermission(auth, Permission.ALBUM_DELETE, id);
const album = await this.findOrFail(id, { withAssets: false });
await this.albumRepository.delete(album);
await this.albumRepository.delete(id);
}
async addAssets(auth: AuthDto, id: string, dto: BulkIdsDto): Promise<BulkIdResponseDto[]> {