fix: creating tags with leading/traling slashes (#12778)

2024-09-18 21:25:13 +02:00
parent caa9b1a041
commit 96516ae4b9
2 changed files with 18 additions and 1 deletions
@@ -140,6 +140,23 @@ describe(TagService.name, () => {
        parent: expect.objectContaining({ id: 'tag-parent' }),
      });
    });
+
+    it('should upsert a tag and ignore leading and trailing slashes', async () => {
+      tagMock.getByValue.mockResolvedValueOnce(null);
+      tagMock.upsertValue.mockResolvedValueOnce(tagStub.parent);
+      tagMock.upsertValue.mockResolvedValueOnce(tagStub.child);
+      await expect(sut.upsert(authStub.admin, { tags: ['/Parent/Child/'] })).resolves.toBeDefined();
+      expect(tagMock.upsertValue).toHaveBeenNthCalledWith(1, {
+        value: 'Parent',
+        userId: 'admin_id',
+        parent: undefined,
+      });
+      expect(tagMock.upsertValue).toHaveBeenNthCalledWith(2, {
+        value: 'Parent/Child',
+        userId: 'admin_id',
+        parent: expect.objectContaining({ id: 'tag-parent' }),
+      });
+    });
  });

  describe('remove', () => {