From 9c7d8e8ad6838c348e19c12664d9172a01f05404 Mon Sep 17 00:00:00 2001 From: aviv <51673860+aviv926@users.noreply.github.com> Date: Sat, 30 Dec 2023 19:37:45 +0200 Subject: [PATCH] New required fixes --- docs/docs/FAQ/Assets-FAQ.md | 8 ++++---- .../{External Library-FAQ.md => External-Library-FAQ.md} | 6 +++--- docs/docs/FAQ/Machine-Learning-FAQ.md | 4 ++-- docs/docs/FAQ/Performance-FAQ.md | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-) rename docs/docs/FAQ/{External Library-FAQ.md => External-Library-FAQ.md} (58%) diff --git a/docs/docs/FAQ/Assets-FAQ.md b/docs/docs/FAQ/Assets-FAQ.md index 69df565208..61d41ca8cf 100644 --- a/docs/docs/FAQ/Assets-FAQ.md +++ b/docs/docs/FAQ/Assets-FAQ.md @@ -30,7 +30,7 @@ For now, it doesn't. ### Does Immich support filtering of NSFW images? -It seems that, this option is not implemented, but it seems that there is an [open discussion about it +This option is not implemented, but there is an [open discussion about it On Github](https://github.com/immich-app/immich/discussions/2451). You can submit a pull request or vote for the discussion. ### Why are there so many thumbnail generation jobs? @@ -47,12 +47,12 @@ All machine learning jobs and thumbnail images are recreated. No. There was a discussion about this in the past but it was [rejected](https://github.com/immich-app/immich/pull/1242), there is an [unofficial way to achieve this](https://gist.github.com/JamesCullum/6604e504318dd326a507108f59ca7dcd). :::danger -If you do choose to use unofficial way, it's important to be aware of the following security risks: +If you do choose to use the unofficial way, it's important to be aware of the following security risks: - The golang:1.19.4-alpine3.17 base image was released a year ago and has [18 vulnerabilities for OpenSSL](https://hub.docker.com/layers/library/golang/1.19.4-alpine3.17/images/sha256-8b532e4f43b6ccab31b2542d132720aa6e22f6164e0ed9d4885ef2d7c8b87aa5?context=explore) -- The image `ghcr.io/jamescullum/multipart-upload-proxy:main` was last released long time ago and has vulnerable versions of OpenSSL and libwebp. +- The image `ghcr.io/jamescullum/multipart-upload-proxy:main` was last updated a long time ago and has vulnerable versions of OpenSSL and libwebp. - The vips-dev package relies on libwebp, which had a major CVE a few months ago. -there may be other vulnerabilities as well. +There may be other vulnerabilities as well. ::: ### How can I move all data (photos, persons, albums) from one user to another? diff --git a/docs/docs/FAQ/External Library-FAQ.md b/docs/docs/FAQ/External-Library-FAQ.md similarity index 58% rename from docs/docs/FAQ/External Library-FAQ.md rename to docs/docs/FAQ/External-Library-FAQ.md index 03422235ad..999ccc8902 100644 --- a/docs/docs/FAQ/External Library-FAQ.md +++ b/docs/docs/FAQ/External-Library-FAQ.md @@ -4,15 +4,15 @@ sidebar_position: 5 # External Library -### Can I add an external library while keeping the existing album structure? +### Can I add an external library while keeping the existing albums structure? -We haven't put in an official mechanism to create album from your external library yet, but there are some [workarounds from the community](https://github.com/immich-app/immich/discussions/4279) which you can find here to help you achieve that. +We haven't put in an official mechanism to create albums from external libraries at the moment., but there are some [workarounds from the community](https://github.com/immich-app/immich/discussions/4279) which you can find here to help you achieve that. ### I got duplicate files in the upload library and the external library It is important to remember that Immich does not filter duplicate files from [external Library](/docs/features/libraries) at the moment. -Upload library and external library different mechanism to detect duplicates: +Upload library and external library use different mechanisms to detect duplicates: - Upload library: hashes the file - External library: uses the file path diff --git a/docs/docs/FAQ/Machine-Learning-FAQ.md b/docs/docs/FAQ/Machine-Learning-FAQ.md index 5e35f1a280..b507726466 100644 --- a/docs/docs/FAQ/Machine-Learning-FAQ.md +++ b/docs/docs/FAQ/Machine-Learning-FAQ.md @@ -5,7 +5,7 @@ sidebar_position: 6 ### How does smart search work? -Immich uses CLIP models, for more information about CLIP and its capabilities can be [read here](https://openai.com/research/clip). +Immich uses CLIP models, for more information about CLIP and its capabilities. Read about it [here](https://openai.com/research/clip). ### How does facial recognition work? @@ -48,7 +48,7 @@ No, this is not supported. Only models listed in the [Huggingface](https://huggi You can change to a multilingual model listed [here](https://huggingface.co/collections/immich-app/multilingual-clip-654eb08c2382f591eeb8c2a7) by going to Administration > Machine Learning Settings > Smart Search and replacing the name of the model. Be sure to re-run Smart Search on all assets after this change. You can then search in over 100 languages. :::note -feel free to make a feature request if there's a model you want to use that isn't in Immich Huggingface list. +Feel free to make a feature request if there's a model you want to use that isn't in [Immich Huggingface list](https://huggingface.co/immich-app). ::: ### Does Immich support Facial Recognition for videos ? diff --git a/docs/docs/FAQ/Performance-FAQ.md b/docs/docs/FAQ/Performance-FAQ.md index ecfb7d2783..0103515751 100644 --- a/docs/docs/FAQ/Performance-FAQ.md +++ b/docs/docs/FAQ/Performance-FAQ.md @@ -32,7 +32,7 @@ You can do it by: 5. Change the settings as needed :::danger -On a normal machine, 2 or 3 concurrent jobs can probably max the CPU, so if you're not hitting those maximums with, say, 30 jobs, +On a normal machine, 2 or 3 concurrent jobs can probably max the CPU, so if you're not hitting those maximums with, say, 30 jobs. Note that storage speed and latency may quickly become the limiting factor; particularly when using HDDs. Do not exaggerate with the amount of jobs because you're probably thoroughly overloading the server.