refactor: rename clip -> smart search (#6713)

server/src/domain/search/dto/search.dto.ts

@@ -14,6 +14,12 @@ export class SearchDto {
   @Optional()
   query?: string;
 
+  @IsBoolean()
+  @Optional()
+  @Transform(toBoolean)
+  smart?: boolean;
+
+  /** @deprecated */
   @IsBoolean()
   @Optional()
   @Transform(toBoolean)

server/src/domain/search/search.service.spec.ts

@@ -180,14 +180,14 @@ describe(SearchService.name, () => {
       expect(assetMock.searchMetadata).not.toHaveBeenCalled();
     });
 
-    it('should throw an error if clip is requested but disabled', async () => {
+    it.each([
+      { key: SystemConfigKey.MACHINE_LEARNING_ENABLED },
+      { key: SystemConfigKey.MACHINE_LEARNING_CLIP_ENABLED },
+    ])('should throw an error if clip is requested but disabled', async ({ key }) => {
       const dto: SearchDto = { q: 'test query', clip: true };
-      configMock.load
-        .mockResolvedValueOnce([{ key: SystemConfigKey.MACHINE_LEARNING_ENABLED, value: false }])
-        .mockResolvedValueOnce([{ key: SystemConfigKey.MACHINE_LEARNING_CLIP_ENABLED, value: false }]);
+      configMock.load.mockResolvedValue([{ key, value: false }]);
 
-      await expect(sut.search(authStub.user1, dto)).rejects.toThrow('CLIP is not enabled');
-      await expect(sut.search(authStub.user1, dto)).rejects.toThrow('CLIP is not enabled');
+      await expect(sut.search(authStub.user1, dto)).rejects.toThrow('Smart search is not enabled');
     });
   });
 });

server/src/domain/search/search.service.ts

@@ -56,23 +56,26 @@ export class SearchService {
   }
 
   async search(auth: AuthDto, dto: SearchDto): Promise<SearchResponseDto> {
+    await this.configCore.requireFeature(FeatureFlag.SEARCH);
     const { machineLearning } = await this.configCore.getConfig();
     const query = dto.q || dto.query;
     if (!query) {
       throw new Error('Missing query');
     }
-    const hasClip = machineLearning.enabled && machineLearning.clip.enabled;
-    if (dto.clip && !hasClip) {
-      throw new Error('CLIP is not enabled');
+
+    let strategy = SearchStrategy.TEXT;
+    if (dto.smart || dto.clip) {
+      await this.configCore.requireFeature(FeatureFlag.SMART_SEARCH);
+      strategy = SearchStrategy.SMART;
     }
-    const strategy = dto.clip ? SearchStrategy.CLIP : SearchStrategy.TEXT;
+
     const userIds = await this.getUserIdsToSearch(auth);
     const withArchived = dto.withArchived || false;
 
     let assets: AssetEntity[] = [];
 
     switch (strategy) {
-      case SearchStrategy.CLIP:
+      case SearchStrategy.SMART:
         const embedding = await this.machineLearning.encodeText(
           machineLearning.url,
           { text: query },