refactor(server): new version check (#9555)

server/src/services/server-info.service.ts

@@ -1,9 +1,6 @@
 import { Inject, Injectable } from '@nestjs/common';
-import { DateTime } from 'luxon';
-import { isDev, serverVersion } from 'src/constants';
 import { StorageCore, StorageFolder } from 'src/cores/storage.core';
 import { SystemConfigCore } from 'src/cores/system-config.core';
-import { OnServerEvent } from 'src/decorators';
 import {
   ServerConfigDto,
   ServerFeaturesDto,
@@ -14,27 +11,20 @@ import {
   UsageByUserDto,
 } from 'src/dtos/server-info.dto';
 import { SystemMetadataKey } from 'src/entities/system-metadata.entity';
-import { ClientEvent, IEventRepository, ServerEvent, ServerEventMap } from 'src/interfaces/event.interface';
 import { ILoggerRepository } from 'src/interfaces/logger.interface';
-import { IServerInfoRepository } from 'src/interfaces/server-info.interface';
 import { IStorageRepository } from 'src/interfaces/storage.interface';
 import { ISystemMetadataRepository } from 'src/interfaces/system-metadata.interface';
 import { IUserRepository, UserStatsQueryResponse } from 'src/interfaces/user.interface';
 import { asHumanReadable } from 'src/utils/bytes';
 import { mimeTypes } from 'src/utils/mime-types';
 import { isDuplicateDetectionEnabled, isFacialRecognitionEnabled, isSmartSearchEnabled } from 'src/utils/misc';
-import { Version } from 'src/utils/version';
 
 @Injectable()
 export class ServerInfoService {
   private configCore: SystemConfigCore;
-  private releaseVersion = serverVersion;
-  private releaseVersionCheckedAt: DateTime | null = null;
 
   constructor(
-    @Inject(IEventRepository) private eventRepository: IEventRepository,
     @Inject(IUserRepository) private userRepository: IUserRepository,
-    @Inject(IServerInfoRepository) private repository: IServerInfoRepository,
     @Inject(IStorageRepository) private storageRepository: IStorageRepository,
     @Inject(ISystemMetadataRepository) private systemMetadataRepository: ISystemMetadataRepository,
     @Inject(ILoggerRepository) private logger: ILoggerRepository,
@@ -43,11 +33,7 @@ export class ServerInfoService {
     this.configCore = SystemConfigCore.create(systemMetadataRepository, this.logger);
   }
 
-  onConnect() {}
-
   async init(): Promise<void> {
-    await this.handleVersionCheck();
-
     const featureFlags = await this.getFeatures();
     if (featureFlags.configFile) {
       await this.systemMetadataRepository.set(SystemMetadataKey.ADMIN_ONBOARDING, {
@@ -77,10 +63,6 @@ export class ServerInfoService {
     return { res: 'pong' };
   }
 
-  getVersion() {
-    return serverVersion;
-  }
-
   async getFeatures(): Promise<ServerFeaturesDto> {
     const { reverseGeocoding, map, machineLearning, trash, oauth, passwordLogin, notifications } =
       await this.configCore.getConfig();
@@ -152,57 +134,4 @@ export class ServerInfoService {
       sidecar: Object.keys(mimeTypes.sidecar),
     };
   }
-
-  async handleVersionCheck(): Promise<boolean> {
-    try {
-      if (isDev) {
-        return true;
-      }
-
-      const { newVersionCheck } = await this.configCore.getConfig();
-      if (!newVersionCheck.enabled) {
-        return true;
-      }
-
-      // check once per hour (max)
-      if (this.releaseVersionCheckedAt && DateTime.now().diff(this.releaseVersionCheckedAt).as('minutes') < 60) {
-        return true;
-      }
-
-      const githubRelease = await this.repository.getGitHubRelease();
-      const githubVersion = Version.fromString(githubRelease.tag_name);
-      const publishedAt = new Date(githubRelease.published_at);
-      this.releaseVersion = githubVersion;
-      this.releaseVersionCheckedAt = DateTime.now();
-
-      if (githubVersion.isNewerThan(serverVersion)) {
-        this.logger.log(`Found ${githubVersion.toString()}, released at ${publishedAt.toLocaleString()}`);
-        this.newReleaseNotification();
-      }
-    } catch (error: Error | any) {
-      this.logger.warn(`Unable to run version check: ${error}`, error?.stack);
-    }
-
-    return true;
-  }
-
-  @OnServerEvent(ServerEvent.WEBSOCKET_CONNECT)
-  onWebsocketConnection({ userId }: ServerEventMap[ServerEvent.WEBSOCKET_CONNECT]) {
-    this.eventRepository.clientSend(ClientEvent.SERVER_VERSION, userId, serverVersion);
-    this.newReleaseNotification(userId);
-  }
-
-  private newReleaseNotification(userId?: string) {
-    const event = ClientEvent.NEW_RELEASE;
-    const payload = {
-      isAvailable: this.releaseVersion.isNewerThan(serverVersion),
-      checkedAt: this.releaseVersionCheckedAt,
-      serverVersion,
-      releaseVersion: this.releaseVersion,
-    };
-
-    userId
-      ? this.eventRepository.clientSend(event, userId, payload)
-      : this.eventRepository.clientBroadcast(event, payload);
-  }
 }