refactor: sync

2024-09-15 20:02:09 +05:30
parent 37b15869d5
commit ded4481190
20 changed files with 307 additions and 86 deletions
@@ -0,0 +1,149 @@
+import 'dart:async';
+
+import 'package:collection/collection.dart';
+import 'package:immich_mobile/domain/interfaces/asset.interface.dart';
+import 'package:immich_mobile/domain/models/asset.model.dart';
+import 'package:immich_mobile/domain/models/user.model.dart';
+import 'package:immich_mobile/service_locator.dart';
+import 'package:immich_mobile/utils/collection_util.dart';
+import 'package:immich_mobile/utils/constants/globals.dart';
+import 'package:immich_mobile/utils/immich_api_client.dart';
+import 'package:immich_mobile/utils/isolate_helper.dart';
+import 'package:immich_mobile/utils/mixins/log_context.mixin.dart';
+import 'package:logging/logging.dart';
+import 'package:openapi/api.dart';
+
+class AssetSyncService with LogContext {
+  const AssetSyncService();
+
+  Future<bool> doFullRemoteSyncForUserDrift(
+    User user, {
+    DateTime? updatedUtil,
+    int? limit,
+  }) async {
+    return await IsolateHelper.run(() async {
+      try {
+        final logger = Logger("SyncService <Isolate>");
+        final syncClient = di<ImmichApiClient>().getSyncApi();
+
+        final chunkSize = limit ?? kFullSyncChunkSize;
+        final updatedTill = updatedUtil ?? DateTime.now().toUtc();
+        updatedUtil ??= DateTime.now().toUtc();
+        String? lastAssetId;
+
+        while (true) {
+          logger.info(
+            "Requesting more chunks from lastId - ${lastAssetId ?? "<initial_fetch>"}",
+          );
+
+          final assets = await syncClient.getFullSyncForUser(AssetFullSyncDto(
+            limit: chunkSize,
+            updatedUntil: updatedTill,
+            lastId: lastAssetId,
+            userId: user.id,
+          ));
+          if (assets == null) {
+            break;
+          }
+
+          final assetsFromServer =
+              assets.map(Asset.remote).sorted(Asset.compareByRemoteId);
+
+          final assetsInDb =
+              await di<IAssetRepository>().fetchRemoteAssetsForIds(
+            assetsFromServer.map((a) => a.remoteId!).toList(),
+          );
+
+          await _syncAssetsToDbDrift(
+            assetsFromServer,
+            assetsInDb,
+            Asset.compareByRemoteId,
+            isRemoteSync: true,
+          );
+
+          lastAssetId = assets.lastOrNull?.id;
+          if (assets.length != chunkSize) break;
+        }
+
+        return true;
+      } catch (e, s) {
+        log.severe("Error performing full sync for user - ${user.name}", e, s);
+      }
+      return false;
+    });
+  }
+
+  Future<void> _syncAssetsToDbDrift(
+    List<Asset> newAssets,
+    List<Asset> existingAssets,
+    Comparator<Asset> compare, {
+    bool? isRemoteSync,
+  }) async {
+    final (toAdd, toUpdate, assetsToRemove) = _diffAssets(
+      newAssets,
+      existingAssets,
+      compare: compare,
+      isRemoteSync: isRemoteSync,
+    );
+
+    final assetsToAdd = toAdd.followedBy(toUpdate);
+
+    await di<IAssetRepository>().addAll(assetsToAdd);
+    await di<IAssetRepository>()
+        .deleteAssetsForIds(assetsToRemove.map((a) => a.id).toList());
+  }
+
+  /// Returns a triple (toAdd, toUpdate, toRemove)
+  (List<Asset>, List<Asset>, List<Asset>) _diffAssets(
+    List<Asset> newAssets,
+    List<Asset> inDb, {
+    bool? isRemoteSync,
+    required Comparator<Asset> compare,
+  }) {
+    // fast paths for trivial cases: reduces memory usage during initial sync etc.
+    if (newAssets.isEmpty && inDb.isEmpty) {
+      return const ([], [], []);
+    } else if (newAssets.isEmpty && isRemoteSync == null) {
+      // remove all from database
+      return (const [], const [], inDb);
+    } else if (inDb.isEmpty) {
+      // add all assets
+      return (newAssets, const [], const []);
+    }
+
+    final List<Asset> toAdd = [];
+    final List<Asset> toUpdate = [];
+    final List<Asset> toRemove = [];
+    CollectionUtil.diffSortedLists(
+      inDb,
+      newAssets,
+      compare: compare,
+      both: (Asset a, Asset b) {
+        if (a == b) {
+          toUpdate.add(a.merge(b));
+          return true;
+        }
+        return false;
+      },
+      // Only in DB (removed asset)
+      onlyFirst: (Asset a) {
+        // We are syncing remote assets, if asset only inDB, then it is removed from remote
+        if (isRemoteSync == true && a.isLocal) {
+          if (a.remoteId != null) {
+            toUpdate.add(a.copyWith(remoteId: () => null));
+          }
+          // We are syncing local assets, mark the asset inDB as local only
+        } else if (isRemoteSync == false && a.isRemote) {
+          if (a.isLocal) {
+            toUpdate.add(a.copyWith(localId: () => null));
+          }
+        } else {
+          toRemove.add(a);
+        }
+      },
+      // Only in remote (new asset)
+      onlySecond: (Asset b) => toAdd.add(b),
+    );
+    return (toAdd, toUpdate, toRemove);
+  }
+}
@@ -132,6 +132,7 @@ class LoginService with LogContext {
      return false;
    }

+    ServiceLocator.registerCurrentUser(user);
    return true;
  }
 }
@@ -1,63 +0,0 @@
-import 'dart:async';
-
-import 'package:immich_mobile/domain/interfaces/asset.interface.dart';
-import 'package:immich_mobile/domain/models/asset.model.dart';
-import 'package:immich_mobile/domain/models/user.model.dart';
-import 'package:immich_mobile/domain/repositories/database.repository.dart';
-import 'package:immich_mobile/service_locator.dart';
-import 'package:immich_mobile/utils/constants/globals.dart';
-import 'package:immich_mobile/utils/immich_api_client.dart';
-import 'package:immich_mobile/utils/isolate_helper.dart';
-import 'package:immich_mobile/utils/mixins/log_context.mixin.dart';
-import 'package:logging/logging.dart';
-import 'package:openapi/api.dart';
-
-class SyncService with LogContext {
-  SyncService();
-
-  Future<bool> doFullSyncForUserDrift(
-    User user, {
-    DateTime? updatedUtil,
-    int? limit,
-  }) async {
-    return await IsolateHelper.run(() async {
-      try {
-        final logger = Logger("SyncService <Isolate>");
-        final syncClient = di<ImmichApiClient>().getSyncApi();
-
-        final chunkSize = limit ?? kFullSyncChunkSize;
-        final updatedTill = updatedUtil ?? DateTime.now().toUtc();
-        updatedUtil ??= DateTime.now().toUtc();
-        String? lastAssetId;
-
-        while (true) {
-          logger.info(
-            "Requesting more chunks from lastId - ${lastAssetId ?? "<initial_fetch>"}",
-          );
-
-          final assets = await syncClient.getFullSyncForUser(AssetFullSyncDto(
-            limit: chunkSize,
-            updatedUntil: updatedTill,
-            lastId: lastAssetId,
-            userId: user.id,
-          ));
-          if (assets == null) {
-            break;
-          }
-
-          await di<IAssetRepository>().addAll(assets.map(Asset.remote));
-
-          lastAssetId = assets.lastOrNull?.id;
-          if (assets.length != chunkSize) break;
-        }
-
-        return true;
-      } catch (e, s) {
-        log.severe("Error performing full sync for user - ${user.name}", e, s);
-      } finally {
-        await di<DriftDatabaseRepository>().close();
-      }
-      return false;
-    });
-  }
-}