refactor: controller tests (#18035)

* feat: controller unit tests

* refactor: controller tests

server/src/controllers/asset.controller.spec.ts

@@ -0,0 +1,118 @@
+import { AssetController } from 'src/controllers/asset.controller';
+import { AssetService } from 'src/services/asset.service';
+import request from 'supertest';
+import { factory } from 'test/small.factory';
+import { ControllerContext, controllerSetup, mockBaseService } from 'test/utils';
+
+describe(AssetController.name, () => {
+  let ctx: ControllerContext;
+
+  beforeAll(async () => {
+    ctx = await controllerSetup(AssetController, [{ provide: AssetService, useValue: mockBaseService(AssetService) }]);
+    return () => ctx.close();
+  });
+
+  beforeEach(() => {
+    ctx.reset();
+  });
+
+  describe('PUT /assets', () => {
+    it('should be an authenticated route', async () => {
+      await request(ctx.getHttpServer()).put(`/assets`);
+      expect(ctx.authenticate).toHaveBeenCalled();
+    });
+  });
+
+  describe('DELETE /assets', () => {
+    it('should be an authenticated route', async () => {
+      await request(ctx.getHttpServer())
+        .delete(`/assets`)
+        .send({ ids: [factory.uuid()] });
+      expect(ctx.authenticate).toHaveBeenCalled();
+    });
+
+    it('should require a valid uuid', async () => {
+      const { status, body } = await request(ctx.getHttpServer())
+        .delete(`/assets`)
+        .send({ ids: ['123'] });
+
+      expect(status).toBe(400);
+      expect(body).toEqual(factory.responses.badRequest(['each value in ids must be a UUID']));
+    });
+  });
+
+  describe('GET /assets/:id', () => {
+    it('should be an authenticated route', async () => {
+      await request(ctx.getHttpServer()).get(`/assets/${factory.uuid()}`);
+      expect(ctx.authenticate).toHaveBeenCalled();
+    });
+
+    it('should require a valid id', async () => {
+      const { status, body } = await request(ctx.getHttpServer()).get(`/assets/123`);
+      expect(status).toBe(400);
+      expect(body).toEqual(factory.responses.badRequest(['id must be a UUID']));
+    });
+  });
+
+  describe('PUT /assets/:id', () => {
+    it('should be an authenticated route', async () => {
+      await request(ctx.getHttpServer()).get(`/assets/123`);
+      expect(ctx.authenticate).toHaveBeenCalled();
+    });
+
+    it('should require a valid id', async () => {
+      const { status, body } = await request(ctx.getHttpServer()).put(`/assets/123`);
+      expect(status).toBe(400);
+      expect(body).toEqual(factory.responses.badRequest(['id must be a UUID']));
+    });
+
+    it('should reject invalid gps coordinates', async () => {
+      for (const test of [
+        { latitude: 12 },
+        { longitude: 12 },
+        { latitude: 12, longitude: 'abc' },
+        { latitude: 'abc', longitude: 12 },
+        { latitude: null, longitude: 12 },
+        { latitude: 12, longitude: null },
+        { latitude: 91, longitude: 12 },
+        { latitude: -91, longitude: 12 },
+        { latitude: 12, longitude: -181 },
+        { latitude: 12, longitude: 181 },
+      ]) {
+        const { status, body } = await request(ctx.getHttpServer()).put(`/assets/${factory.uuid()}`).send(test);
+        expect(status).toBe(400);
+        expect(body).toEqual(factory.responses.badRequest());
+      }
+    });
+
+    it('should reject invalid rating', async () => {
+      for (const test of [{ rating: 7 }, { rating: 3.5 }, { rating: null }]) {
+        const { status, body } = await request(ctx.getHttpServer()).put(`/assets/${factory.uuid()}`).send(test);
+        expect(status).toBe(400);
+        expect(body).toEqual(factory.responses.badRequest());
+      }
+    });
+  });
+
+  describe('GET /assets/statistics', () => {
+    it('should be an authenticated route', async () => {
+      await request(ctx.getHttpServer()).get(`/assets/statistics`);
+      expect(ctx.authenticate).toHaveBeenCalled();
+    });
+  });
+
+  describe('GET /assets/random', () => {
+    it('should be an authenticated route', async () => {
+      await request(ctx.getHttpServer()).get(`/assets/random`);
+      expect(ctx.authenticate).toHaveBeenCalled();
+    });
+
+    it('should not allow count to be a string', async () => {
+      const { status, body } = await request(ctx.getHttpServer()).get('/assets/random?count=ABC');
+      expect(status).toBe(400);
+      expect(body).toEqual(
+        factory.responses.badRequest(['count must be a positive number', 'count must be an integer number']),
+      );
+    });
+  });
+});