From f406ba1e6c4fb85e9d246c948ffa3540cffd1ddc Mon Sep 17 00:00:00 2001 From: mertalev <101130780+mertalev@users.noreply.github.com> Date: Thu, 18 Sep 2025 20:31:29 -0400 Subject: [PATCH] add back client parameter for testing --- .../lib/infrastructure/repositories/sync_api.repository.dart | 4 +++- .../repositories/sync_api_repository_test.dart | 5 ----- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/mobile/lib/infrastructure/repositories/sync_api.repository.dart b/mobile/lib/infrastructure/repositories/sync_api.repository.dart index 7ead5b7d83..4498d643ee 100644 --- a/mobile/lib/infrastructure/repositories/sync_api.repository.dart +++ b/mobile/lib/infrastructure/repositories/sync_api.repository.dart @@ -25,8 +25,10 @@ class SyncApiRepository { Future Function(List, Function() abort, Function() reset) onData, { Function()? onReset, int batchSize = kSyncEventBatchSize, + http.Client? httpClient, }) async { final stopwatch = Stopwatch()..start(); + final client = httpClient ?? _client; final endpoint = "${_api.apiClient.basePath}/sync/stream"; final headers = {'Content-Type': 'application/json', 'Accept': 'application/jsonlines+json'}; @@ -78,7 +80,7 @@ class SyncApiRepository { final reset = onReset ?? () {}; try { - final response = await _client.send(request); + final response = await client.send(request); if (response.statusCode != 200) { final errorBody = await response.stream.bytesToString(); diff --git a/mobile/test/infrastructure/repositories/sync_api_repository_test.dart b/mobile/test/infrastructure/repositories/sync_api_repository_test.dart index 467e19bf3f..d38dda2edc 100644 --- a/mobile/test/infrastructure/repositories/sync_api_repository_test.dart +++ b/mobile/test/infrastructure/repositories/sync_api_repository_test.dart @@ -118,7 +118,6 @@ void main() { expect(onDataCallCount, 1); expect(abortWasCalledInCallback, isTrue); expect(receivedEventsBatch1.length, testBatchSize); - verify(() => mockHttpClient.close()).called(1); }); test('streamChanges does not process remaining lines in finally block if aborted', () async { @@ -159,7 +158,6 @@ void main() { expect(onDataCallCount, 1); expect(abortWasCalledInCallback, isTrue); - verify(() => mockHttpClient.close()).called(1); }); test('streamChanges processes remaining lines in finally block if not aborted', () async { @@ -204,7 +202,6 @@ void main() { expect(onDataCallCount, 2); expect(receivedEventsBatch1.length, testBatchSize); expect(receivedEventsBatch2.length, 1); - verify(() => mockHttpClient.close()).called(1); }); test('streamChanges handles stream error gracefully', () async { @@ -229,7 +226,6 @@ void main() { await expectLater(streamChangesFuture, throwsA(streamError)); expect(onDataCallCount, 0); - verify(() => mockHttpClient.close()).called(1); }); test('streamChanges throws ApiException on non-200 status code', () async { @@ -257,6 +253,5 @@ void main() { ); expect(onDataCallCount, 0); - verify(() => mockHttpClient.close()).called(1); }); }