chore(server,cli,web): housekeeping and stricter code style (#6751)

* add unicorn to eslint

* fix lint errors for cli

* fix merge

* fix album name extraction

* Update cli/src/commands/upload.command.ts

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>

* es2k23

* use lowercase os

* return undefined album name

* fix bug in asset response dto

* auto fix issues

* fix server code style

* es2022 and formatting

* fix compilation error

* fix test

* fix config load

* fix last lint errors

* set string type

* bump ts

* start work on web

* web formatting

* Fix UUIDParamDto as UUIDParamDto

* fix library service lint

* fix web errors

* fix errors

* formatting

* wip

* lints fixed

* web can now start

* alphabetical package json

* rename error

* chore: clean up

---------

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>

server/src/domain/album/album-response.dto.ts

@@ -27,10 +27,11 @@ export class AlbumResponseDto {
 export const mapAlbum = (entity: AlbumEntity, withAssets: boolean): AlbumResponseDto => {
   const sharedUsers: UserResponseDto[] = [];
 
-  entity.sharedUsers?.forEach((user) => {
-    const userDto = mapUser(user);
-    sharedUsers.push(userDto);
-  });
+  if (entity.sharedUsers) {
+    for (const user of entity.sharedUsers) {
+      sharedUsers.push(mapUser(user));
+    }
+  }
 
   const assets = entity.assets || [];
 
@@ -41,9 +42,7 @@ export const mapAlbum = (entity: AlbumEntity, withAssets: boolean): AlbumRespons
   let endDate = assets.at(-1)?.fileCreatedAt || undefined;
   // Swap dates if start date is greater than end date.
   if (startDate && endDate && startDate > endDate) {
-    const temp = startDate;
-    startDate = endDate;
-    endDate = temp;
+    [startDate, endDate] = [endDate, startDate];
   }
 
   return {

server/src/domain/album/album.service.ts

@@ -69,19 +69,17 @@ export class AlbumService {
 
     // Get asset count for each album. Then map the result to an object:
     // { [albumId]: assetCount }
-    const albumMetadataForIds = await this.albumRepository.getMetadataForIds(albums.map((album) => album.id));
-    const albumMetadataForIdsObj: Record<string, AlbumAssetCount> = albumMetadataForIds.reduce(
-      (obj: Record<string, AlbumAssetCount>, { albumId, assetCount, startDate, endDate }) => {
-        obj[albumId] = {
-          albumId,
-          assetCount,
-          startDate,
-          endDate,
-        };
-        return obj;
-      },
-      {},
-    );
+    const results = await this.albumRepository.getMetadataForIds(albums.map((album) => album.id));
+    const albumMetadata: Record<string, AlbumAssetCount> = {};
+    for (const metadata of results) {
+      const { albumId, assetCount, startDate, endDate } = metadata;
+      albumMetadata[albumId] = {
+        albumId,
+        assetCount,
+        startDate,
+        endDate,
+      };
+    }
 
     return Promise.all(
       albums.map(async (album) => {
@@ -89,9 +87,9 @@ export class AlbumService {
         return {
           ...mapAlbumWithoutAssets(album),
           sharedLinks: undefined,
-          startDate: albumMetadataForIdsObj[album.id].startDate,
-          endDate: albumMetadataForIdsObj[album.id].endDate,
-          assetCount: albumMetadataForIdsObj[album.id].assetCount,
+          startDate: albumMetadata[album.id].startDate,
+          endDate: albumMetadata[album.id].endDate,
+          assetCount: albumMetadata[album.id].assetCount,
           lastModifiedAssetTimestamp: lastModifiedAsset?.fileModifiedAt,
         };
       }),