chore(server,cli,web): housekeeping and stricter code style (#6751)

* add unicorn to eslint

* fix lint errors for cli

* fix merge

* fix album name extraction

* Update cli/src/commands/upload.command.ts

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>

* es2k23

* use lowercase os

* return undefined album name

* fix bug in asset response dto

* auto fix issues

* fix server code style

* es2022 and formatting

* fix compilation error

* fix test

* fix config load

* fix last lint errors

* set string type

* bump ts

* start work on web

* web formatting

* Fix UUIDParamDto as UUIDParamDto

* fix library service lint

* fix web errors

* fix errors

* formatting

* wip

* lints fixed

* web can now start

* alphabetical package json

* rename error

* chore: clean up

---------

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>

server/src/domain/server-info/server-info.service.spec.ts

@@ -71,12 +71,12 @@ describe(ServerInfoService.name, () => {
 
       await expect(sut.getInfo()).resolves.toEqual({
         diskAvailable: '293.0 KiB',
-        diskAvailableRaw: 300000,
+        diskAvailableRaw: 300_000,
         diskSize: '488.3 KiB',
-        diskSizeRaw: 500000,
+        diskSizeRaw: 500_000,
         diskUsagePercentage: 60,
         diskUse: '293.0 KiB',
-        diskUseRaw: 300000,
+        diskUseRaw: 300_000,
       });
 
       expect(storageMock.checkDiskUsage).toHaveBeenCalledWith('upload/library');
@@ -87,12 +87,12 @@ describe(ServerInfoService.name, () => {
 
       await expect(sut.getInfo()).resolves.toEqual({
         diskAvailable: '286.1 MiB',
-        diskAvailableRaw: 300000000,
+        diskAvailableRaw: 300_000_000,
         diskSize: '476.8 MiB',
-        diskSizeRaw: 500000000,
+        diskSizeRaw: 500_000_000,
         diskUsagePercentage: 60,
         diskUse: '286.1 MiB',
-        diskUseRaw: 300000000,
+        diskUseRaw: 300_000_000,
       });
 
       expect(storageMock.checkDiskUsage).toHaveBeenCalledWith('upload/library');
@@ -107,12 +107,12 @@ describe(ServerInfoService.name, () => {
 
       await expect(sut.getInfo()).resolves.toEqual({
         diskAvailable: '279.4 GiB',
-        diskAvailableRaw: 300000000000,
+        diskAvailableRaw: 300_000_000_000,
         diskSize: '465.7 GiB',
-        diskSizeRaw: 500000000000,
+        diskSizeRaw: 500_000_000_000,
         diskUsagePercentage: 60,
         diskUse: '279.4 GiB',
-        diskUseRaw: 300000000000,
+        diskUseRaw: 300_000_000_000,
       });
 
       expect(storageMock.checkDiskUsage).toHaveBeenCalledWith('upload/library');
@@ -127,12 +127,12 @@ describe(ServerInfoService.name, () => {
 
       await expect(sut.getInfo()).resolves.toEqual({
         diskAvailable: '272.8 TiB',
-        diskAvailableRaw: 300000000000000,
+        diskAvailableRaw: 300_000_000_000_000,
         diskSize: '454.7 TiB',
-        diskSizeRaw: 500000000000000,
+        diskSizeRaw: 500_000_000_000_000,
         diskUsagePercentage: 60,
         diskUse: '272.8 TiB',
-        diskUseRaw: 300000000000000,
+        diskUseRaw: 300_000_000_000_000,
       });
 
       expect(storageMock.checkDiskUsage).toHaveBeenCalledWith('upload/library');
@@ -147,12 +147,12 @@ describe(ServerInfoService.name, () => {
 
       await expect(sut.getInfo()).resolves.toEqual({
         diskAvailable: '266.5 PiB',
-        diskAvailableRaw: 300000000000000000,
+        diskAvailableRaw: 300_000_000_000_000_000,
         diskSize: '444.1 PiB',
-        diskSizeRaw: 500000000000000000,
+        diskSizeRaw: 500_000_000_000_000_000,
         diskUsagePercentage: 60,
         diskUse: '266.5 PiB',
-        diskUseRaw: 300000000000000000,
+        diskUseRaw: 300_000_000_000_000_000,
       });
 
       expect(storageMock.checkDiskUsage).toHaveBeenCalledWith('upload/library');
@@ -219,7 +219,7 @@ describe(ServerInfoService.name, () => {
           userName: '1 User',
           photos: 10,
           videos: 11,
-          usage: 12345,
+          usage: 12_345,
           quotaSizeInBytes: 0,
         },
         {
@@ -227,7 +227,7 @@ describe(ServerInfoService.name, () => {
           userName: '2 User',
           photos: 10,
           videos: 20,
-          usage: 123456,
+          usage: 123_456,
           quotaSizeInBytes: 0,
         },
         {
@@ -235,7 +235,7 @@ describe(ServerInfoService.name, () => {
           userName: '3 User',
           photos: 100,
           videos: 0,
-          usage: 987654,
+          usage: 987_654,
           quotaSizeInBytes: 0,
         },
       ]);
@@ -243,12 +243,12 @@ describe(ServerInfoService.name, () => {
       await expect(sut.getStatistics()).resolves.toEqual({
         photos: 120,
         videos: 31,
-        usage: 1123455,
+        usage: 1_123_455,
         usageByUser: [
           {
             photos: 10,
             quotaSizeInBytes: 0,
-            usage: 12345,
+            usage: 12_345,
             userName: '1 User',
             userId: 'user1',
             videos: 11,
@@ -256,7 +256,7 @@ describe(ServerInfoService.name, () => {
           {
             photos: 10,
             quotaSizeInBytes: 0,
-            usage: 123456,
+            usage: 123_456,
             userName: '2 User',
             userId: 'user2',
             videos: 20,
@@ -264,7 +264,7 @@ describe(ServerInfoService.name, () => {
           {
             photos: 100,
             quotaSizeInBytes: 0,
-            usage: 987654,
+            usage: 987_654,
             userName: '3 User',
             userId: 'user3',
             videos: 0,

server/src/domain/server-info/server-info.service.ts

@@ -67,7 +67,7 @@ export class ServerInfoService {
     serverInfo.diskAvailableRaw = diskInfo.available;
     serverInfo.diskSizeRaw = diskInfo.total;
     serverInfo.diskUseRaw = diskInfo.total - diskInfo.free;
-    serverInfo.diskUsagePercentage = parseFloat(usagePercentage);
+    serverInfo.diskUsagePercentage = Number.parseFloat(usagePercentage);
     return serverInfo;
   }