chore(server,cli,web): housekeeping and stricter code style (#6751)

* add unicorn to eslint

* fix lint errors for cli

* fix merge

* fix album name extraction

* Update cli/src/commands/upload.command.ts

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>

* es2k23

* use lowercase os

* return undefined album name

* fix bug in asset response dto

* auto fix issues

* fix server code style

* es2022 and formatting

* fix compilation error

* fix test

* fix config load

* fix last lint errors

* set string type

* bump ts

* start work on web

* web formatting

* Fix UUIDParamDto as UUIDParamDto

* fix library service lint

* fix web errors

* fix errors

* formatting

* wip

* lints fixed

* web can now start

* alphabetical package json

* rename error

* chore: clean up

---------

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>

server/src/domain/user/response-dto/user-response.dto.ts

@@ -5,10 +5,7 @@ import { IsEnum } from 'class-validator';
 export const getRandomAvatarColor = (user: UserEntity): UserAvatarColor => {
   const values = Object.values(UserAvatarColor);
   const randomIndex = Math.floor(
-    user.email
-      .split('')
-      .map((letter) => letter.charCodeAt(0))
-      .reduce((a, b) => a + b, 0) % values.length,
+    [...user.email].map((letter) => letter.codePointAt(0) ?? 0).reduce((a, b) => a + b, 0) % values.length,
   );
   return values[randomIndex] as UserAvatarColor;
 };

server/src/domain/user/user.core.ts

@@ -1,6 +1,6 @@
 import { LibraryType, UserEntity } from '@app/infra/entities';
 import { BadRequestException, ForbiddenException } from '@nestjs/common';
-import path from 'path';
+import path from 'node:path';
 import sanitize from 'sanitize-filename';
 import { ICryptoRepository, ILibraryRepository, IUserRepository } from '../repositories';
 import { UserResponseDto } from './response-dto';
@@ -97,7 +97,7 @@ export class UserCore {
       payload.password = await this.cryptoRepository.hashBcrypt(payload.password, SALT_ROUNDS);
     }
     if (payload.storageLabel) {
-      payload.storageLabel = sanitize(payload.storageLabel.replace(/\./g, ''));
+      payload.storageLabel = sanitize(payload.storageLabel.replaceAll('.', ''));
     }
     const userEntity = await this.userRepository.create(payload);
     await this.libraryRepository.create({

server/src/domain/user/user.service.spec.ts

@@ -418,7 +418,7 @@ describe(UserService.name, () => {
 
     it('should default to a random password', async () => {
       userMock.getAdmin.mockResolvedValue(userStub.admin);
-      const ask = jest.fn().mockResolvedValue(undefined);
+      const ask = jest.fn().mockImplementation(() => {});
 
       const response = await sut.resetAdminPassword(ask);
 

server/src/domain/user/user.service.ts

@@ -1,7 +1,7 @@
 import { UserEntity } from '@app/infra/entities';
 import { ImmichLogger } from '@app/infra/logger';
 import { BadRequestException, ForbiddenException, Inject, Injectable, NotFoundException } from '@nestjs/common';
-import { randomBytes } from 'crypto';
+import { randomBytes } from 'node:crypto';
 import { AuthDto } from '../auth';
 import { CacheControl, ImmichFileResponse } from '../domain.util';
 import { IEntityJob, JobName } from '../job';
@@ -39,7 +39,7 @@ export class UserService {
 
   async getAll(auth: AuthDto, isAll: boolean): Promise<UserResponseDto[]> {
     const users = await this.userRepository.getList({ withDeleted: !isAll });
-    return users.map(mapUser);
+    return users.map((user) => mapUser(user));
   }
 
   async get(userId: string): Promise<UserResponseDto> {
@@ -125,7 +125,7 @@ export class UserService {
     }
 
     const providedPassword = await ask(mapUser(admin));
-    const password = providedPassword || randomBytes(24).toString('base64').replace(/\W/g, '');
+    const password = providedPassword || randomBytes(24).toString('base64').replaceAll(/\W/g, '');
 
     await this.userCore.updateUser(admin, admin.id, { password });
 
@@ -188,9 +188,10 @@ export class UserService {
       return false;
     }
 
-    const msInDay = 86400000;
+    // TODO use luxon for date calculation
+    const msInDay = 86_400_000;
     const msDeleteWait = msInDay * 7;
-    const msSinceDelete = new Date().getTime() - (Date.parse(user.deletedAt.toString()) || 0);
+    const msSinceDelete = Date.now() - (Date.parse(user.deletedAt.toString()) || 0);
 
     return msSinceDelete >= msDeleteWait;
   }