chore(server,cli,web): housekeeping and stricter code style (#6751)

* add unicorn to eslint

* fix lint errors for cli

* fix merge

* fix album name extraction

* Update cli/src/commands/upload.command.ts

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>

* es2k23

* use lowercase os

* return undefined album name

* fix bug in asset response dto

* auto fix issues

* fix server code style

* es2022 and formatting

* fix compilation error

* fix test

* fix config load

* fix last lint errors

* set string type

* bump ts

* start work on web

* web formatting

* Fix UUIDParamDto as UUIDParamDto

* fix library service lint

* fix web errors

* fix errors

* formatting

* wip

* lints fixed

* web can now start

* alphabetical package json

* rename error

* chore: clean up

---------

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>

web/src/routes/(user)/albums/+page.svelte

@@ -227,11 +227,8 @@
   };
 
   const handleChangeListMode = () => {
-    if ($albumViewSettings.view === AlbumViewMode.Cover) {
-      $albumViewSettings.view = AlbumViewMode.List;
-    } else {
-      $albumViewSettings.view = AlbumViewMode.Cover;
-    }
+    $albumViewSettings.view =
+      $albumViewSettings.view === AlbumViewMode.Cover ? AlbumViewMode.List : AlbumViewMode.Cover;
   };
 </script>
 
@@ -285,14 +282,14 @@
       </div>
     </LinkButton>
   </div>
-  {#if $albums.length !== 0}
+  {#if $albums.length > 0}
     <!-- Album Card -->
     {#if $albumViewSettings.view === AlbumViewMode.Cover}
       <div class="grid grid-cols-[repeat(auto-fill,minmax(14rem,1fr))]">
-        {#each $albums as album, idx (album.id)}
+        {#each $albums as album, index (album.id)}
           <a data-sveltekit-preload-data="hover" href="{AppRoute.ALBUMS}/{album.id}" animate:flip={{ duration: 200 }}>
             <AlbumCard
-              preload={idx < 20}
+              preload={index < 20}
               {album}
               on:showalbumcontextmenu={(e) => showAlbumContextMenu(e.detail, album)}
             />

web/src/routes/(user)/albums/[albumId]/+page.svelte

@@ -111,14 +111,10 @@
   const { selectedAssets: timelineSelected } = timelineInteractionStore;
 
   $: isOwned = $user.id == album.ownerId;
-  $: isAllUserOwned = Array.from($selectedAssets).every((asset) => asset.ownerId === $user.id);
-  $: isAllFavorite = Array.from($selectedAssets).every((asset) => asset.isFavorite);
+  $: isAllUserOwned = [...$selectedAssets].every((asset) => asset.ownerId === $user.id);
+  $: isAllFavorite = [...$selectedAssets].every((asset) => asset.isFavorite);
   $: {
-    if (isShowActivity) {
-      assetGridWidth = globalWidth - (globalWidth < 768 ? 360 : 460);
-    } else {
-      assetGridWidth = globalWidth;
-    }
+    assetGridWidth = isShowActivity ? globalWidth - (globalWidth < 768 ? 360 : 460) : globalWidth;
   }
   $: showActivityStatus =
     album.sharedUsers.length > 0 && !$showAssetViewer && (album.isActivityEnabled || $numberOfComments > 0);
@@ -157,7 +153,7 @@
         message: `Activity is ${album.isActivityEnabled ? 'enabled' : 'disabled'}`,
       });
     } catch (error) {
-      handleError(error, `Can't ${!album.isActivityEnabled ? 'enable' : 'disable'} activity`);
+      handleError(error, `Can't ${album.isActivityEnabled ? 'disable' : 'enable'} activity`);
     }
   };
 
@@ -224,10 +220,11 @@
     }
     const ctrl = event.ctrlKey;
     switch (event.key) {
-      case 'Enter':
+      case 'Enter': {
         if (ctrl && event.target === textArea) {
           textArea.blur();
         }
+      }
     }
   };
 
@@ -302,7 +299,7 @@
   };
 
   const handleAddAssets = async () => {
-    const assetIds = Array.from($timelineSelected).map((asset) => asset.id);
+    const assetIds = [...$timelineSelected].map((asset) => asset.id);
 
     try {
       const { data: results } = await api.albumApi.addAssetsToAlbum({
@@ -352,7 +349,7 @@
       const { data } = await api.albumApi.addUsersToAlbum({
         id: album.id,
         addUsersDto: {
-          sharedUserIds: Array.from(users).map(({ id }) => id),
+          sharedUserIds: [...users].map(({ id }) => id),
         },
       });
 
@@ -373,8 +370,8 @@
     try {
       await refreshAlbum();
       viewMode = album.sharedUsers.length > 1 ? ViewMode.SELECT_USERS : ViewMode.VIEW;
-    } catch (e) {
-      handleError(e, 'Error deleting share users');
+    } catch (error) {
+      handleError(error, 'Error deleting share users');
     }
   };
 

web/src/routes/(user)/albums/__tests__/albums.bloc.spec.ts

@@ -20,7 +20,9 @@ describe('Albums BLoC', () => {
   afterEach(() => {
     const notifications = get(notificationController.notificationList);
 
-    notifications.forEach((notification) => notificationController.removeNotificationById(notification.id));
+    for (const notification of notifications) {
+      notificationController.removeNotificationById(notification.id);
+    }
   });
 
   it('inits with provided albums', () => {

web/src/routes/(user)/albums/albums.bloc.ts

@@ -3,10 +3,10 @@ import { notificationController, NotificationType } from '$lib/components/shared
 import { type AlbumResponseDto, api } from '@api';
 import { derived, get, writable } from 'svelte/store';
 
-type AlbumsProps = { albums: AlbumResponseDto[] };
+type AlbumsProperties = { albums: AlbumResponseDto[] };
 
-export const useAlbums = (props: AlbumsProps) => {
-  const albums = writable([...props.albums]);
+export const useAlbums = (properties: AlbumsProperties) => {
+  const albums = writable([...properties.albums]);
   const contextMenuPosition = writable<OnShowContextMenuDetail>({ x: 0, y: 0 });
   const contextMenuTargetAlbum = writable<AlbumResponseDto | undefined>();
   const isShowContextMenu = derived(contextMenuTargetAlbum, ($selectedAlbum) => !!$selectedAlbum);