chore(server,cli,web): housekeeping and stricter code style (#6751)

* add unicorn to eslint

* fix lint errors for cli

* fix merge

* fix album name extraction

* Update cli/src/commands/upload.command.ts

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>

* es2k23

* use lowercase os

* return undefined album name

* fix bug in asset response dto

* auto fix issues

* fix server code style

* es2022 and formatting

* fix compilation error

* fix test

* fix config load

* fix last lint errors

* set string type

* bump ts

* start work on web

* web formatting

* Fix UUIDParamDto as UUIDParamDto

* fix library service lint

* fix web errors

* fix errors

* formatting

* wip

* lints fixed

* web can now start

* alphabetical package json

* rename error

* chore: clean up

---------

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>

web/src/routes/(user)/people/+page.svelte

@@ -90,9 +90,10 @@
       return;
     }
     switch (event.key) {
-      case 'Escape':
+      case 'Escape': {
         handleCloseClick();
         return;
+      }
     }
   };
 
@@ -288,10 +289,8 @@
       }
       return;
     }
-    if (!force) {
-      if (people.length < maximumLengthSearchPeople && searchName.startsWith(searchWord)) {
-        return;
-      }
+    if (!force && people.length < maximumLengthSearchPeople && searchName.startsWith(searchWord)) {
+      return;
     }
 
     const timeout = setTimeout(() => (isSearchingPeople = true), timeBeforeShowLoadingSpinner);
@@ -417,7 +416,7 @@
   </FullScreenModal>
 {/if}
 
-<UserPageLayout title="People" description={countTotalPeople !== 0 ? `(${countTotalPeople.toString()})` : undefined}>
+<UserPageLayout title="People" description={countTotalPeople === 0 ? undefined : `(${countTotalPeople.toString()})`}>
   <svelte:fragment slot="buttons">
     {#if countTotalPeople > 0}
       <div class="flex gap-2 items-center justify-center">
@@ -445,11 +444,11 @@
 
   {#if countVisiblePeople > 0}
     <div class="grid grid-cols-2 sm:grid-cols-3 lg:grid-cols-5 xl:grid-cols-7 2xl:grid-cols-9 gap-1">
-      {#each people as person, idx (person.id)}
+      {#each people as person, index (person.id)}
         {#if !person.isHidden && (searchName ? searchedPeopleLocal.some((searchedPerson) => searchedPerson.id === person.id) : true)}
           <PeopleCard
             {person}
-            preload={idx < 20}
+            preload={index < 20}
             on:change-name={() => handleChangeName(person)}
             on:set-birth-date={() => handleSetBirthDate(person)}
             on:merge-people={() => handleMergePeople(person)}
@@ -519,7 +518,7 @@
     screenHeight={innerHeight}
   >
     <div class="grid grid-cols-2 sm:grid-cols-3 lg:grid-cols-5 xl:grid-cols-7 2xl:grid-cols-9 gap-1">
-      {#each people as person, idx (person.id)}
+      {#each people as person, index (person.id)}
         <button
           class="relative"
           on:click={() => (person.isHidden = !person.isHidden)}
@@ -527,7 +526,7 @@
           on:mouseleave={() => (eyeColorMap[person.id] = 'white')}
         >
           <ImageThumbnail
-            preload={searchName !== '' || idx < 20}
+            preload={searchName !== '' || index < 20}
             bind:hidden={person.isHidden}
             shadow
             url={api.getPeopleThumbnailUrl(person.id)}

web/src/routes/(user)/people/[personId]/+page.svelte

@@ -108,14 +108,14 @@
     isSearchingPeople = false;
   };
 
-  $: isAllArchive = Array.from($selectedAssets).every((asset) => asset.isArchived);
-  $: isAllFavorite = Array.from($selectedAssets).every((asset) => asset.isFavorite);
+  $: isAllArchive = [...$selectedAssets].every((asset) => asset.isArchived);
+  $: isAllFavorite = [...$selectedAssets].every((asset) => asset.isFavorite);
   $: $onPersonThumbnail === data.person.id &&
     (thumbnailData = api.getPeopleThumbnailUrl(data.person.id) + `?now=${Date.now()}`);
 
   $: {
     if (people) {
-      suggestedPeople = !name ? [] : searchNameLocal(name, people, 5, data.person.id);
+      suggestedPeople = name ? searchNameLocal(name, people, 5, data.person.id) : [];
     }
   }
 
@@ -158,7 +158,7 @@
   });
 
   const handleUnmerge = () => {
-    $assetStore.removeAssets(Array.from($selectedAssets).map((a) => a.id));
+    $assetStore.removeAssets([...$selectedAssets].map((a) => a.id));
     assetInteractionStore.clearMultiselect();
     viewMode = ViewMode.VIEW_ASSETS;
   };
@@ -352,7 +352,7 @@
 
 {#if viewMode === ViewMode.UNASSIGN_ASSETS}
   <UnMergeFaceSelector
-    assetIds={Array.from($selectedAssets).map((a) => a.id)}
+    assetIds={[...$selectedAssets].map((a) => a.id)}
     personAssets={data.person}
     on:close={() => (viewMode = ViewMode.VIEW_ASSETS)}
     on:confirm={handleUnmerge}