Version v1.91.3

* stricter dim size check

* remove unused import

* added null check

cli/src/api/open-api/api.ts

@@ -4,7 +4,7 @@
  * Immich
  * Immich API
  *
- * The version of the OpenAPI document: 1.91.1
+ * The version of the OpenAPI document: 1.91.3
  * 
  *
  * NOTE: This class is auto generated by OpenAPI Generator (https://openapi-generator.tech).

cli/src/api/open-api/base.ts

@@ -4,7 +4,7 @@
  * Immich
  * Immich API
  *
- * The version of the OpenAPI document: 1.91.1
+ * The version of the OpenAPI document: 1.91.3
  * 
  *
  * NOTE: This class is auto generated by OpenAPI Generator (https://openapi-generator.tech).

cli/src/api/open-api/common.ts

@@ -4,7 +4,7 @@
  * Immich
  * Immich API
  *
- * The version of the OpenAPI document: 1.91.1
+ * The version of the OpenAPI document: 1.91.3
  * 
  *
  * NOTE: This class is auto generated by OpenAPI Generator (https://openapi-generator.tech).

cli/src/api/open-api/configuration.ts

@@ -4,7 +4,7 @@
  * Immich
  * Immich API
  *
- * The version of the OpenAPI document: 1.91.1
+ * The version of the OpenAPI document: 1.91.3
  * 
  *
  * NOTE: This class is auto generated by OpenAPI Generator (https://openapi-generator.tech).

cli/src/api/open-api/index.ts

@@ -4,7 +4,7 @@
  * Immich
  * Immich API
  *
- * The version of the OpenAPI document: 1.91.1
+ * The version of the OpenAPI document: 1.91.3
  * 
  *
  * NOTE: This class is auto generated by OpenAPI Generator (https://openapi-generator.tech).

docs/docs/guides/external-library.md

@@ -16,9 +16,6 @@ Edit `docker-compose.yml` to add two new mount points under `volumes:`
 
 Be sure to add exactly the same line to both `immich-server:` and `immich-microservices:`.
 
-[Question for the devs: Is editing docker-compose.yml really the desirable way to solve this problem?
-I assumed user changes were supposed to be kept to .env?]
-
 Edit `.env` to define `EXTERNAL_PATH`, substituting in the correct path for your computer:
 
 ```
@@ -87,7 +84,7 @@ In the Immich web UI:
 - Save the new path
   <img src={require('./img/path-save.png').default} width="50%" title="Path Save button" />
 
-- Click the three-dots menu and select **Scan New Library Files** [I'm not sure whether this is necessary]
+- Click the three-dots menu and select **Scan New Library Files**
   <img src={require('./img/scan-new-library-files.png').default} width="50%" title="Scan New Library Files menu option" />
 
 # Confirm stuff is happening

docs/docs/install/docker-compose.mdx

@@ -55,7 +55,7 @@ Optionally, you can use the [`hwaccel.yml`][hw-file] file to enable hardware acc
 
 ### Step 3 - Start the containers
 
-From the directory you created in Step 1, (which should now contain your customized `docker-compose.yml` and `.env` files) run `docker-compose up -d`.
+From the directory you created in Step 1, (which should now contain your customized `docker-compose.yml` and `.env` files) run `docker compose up -d`.
 
 ```bash title="Start the containers using docker compose command"
 docker compose up -d

machine-learning/Dockerfile

@@ -25,6 +25,11 @@ ENV NODE_ENV=production \
   PATH="/opt/venv/bin:$PATH" \
   PYTHONPATH=/usr/src
 
+# prevent core dumps
+RUN echo "hard core 0" >> /etc/security/limits.conf && \
+    echo "fs.suid_dumpable 0" >> /etc/sysctl.conf && \
+    echo 'ulimit -S -c 0 > /dev/null 2>&1' >> /etc/profile
+
 COPY --from=builder /opt/venv /opt/venv
 COPY start.sh log_conf.json ./
 COPY app .

machine-learning/pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "machine-learning"
-version = "1.91.1"
+version = "1.91.3"
 description = ""
 authors = ["Hau Tran <alex.tran1502@gmail.com>"]
 readme = "README.md"

mobile/android/fastlane/Fastfile

@@ -36,7 +36,7 @@ platform :android do
       build_type: 'Release',
       properties: {
         "android.injected.version.code" => 115,
-        "android.injected.version.name" => "1.91.1",
+        "android.injected.version.name" => "1.91.3",
       }
     )
     upload_to_play_store(skip_upload_apk: true, skip_upload_images: true, skip_upload_screenshots: true, aab: '../build/app/outputs/bundle/release/app-release.aab')

mobile/ios/fastlane/Fastfile

@@ -19,7 +19,7 @@ platform :ios do
   desc "iOS Beta"
   lane :beta do
     increment_version_number(
-      version_number: "1.91.1"
+      version_number: "1.91.3"
     )
     increment_build_number(
       build_number: latest_testflight_build_number + 1,

mobile/openapi/README.md

@@ -3,7 +3,7 @@ Immich API
 
 This Dart package is automatically generated by the [OpenAPI Generator](https://openapi-generator.tech) project:
 
-- API version: 1.91.1
+- API version: 1.91.3
 - Build package: org.openapitools.codegen.languages.DartClientCodegen
 
 ## Requirements

mobile/pubspec.yaml

@@ -2,7 +2,7 @@ name: immich_mobile
 description: Immich - selfhosted backup media file on mobile phone
 
 publish_to: "none"
-version: 1.91.1+115
+version: 1.91.3+115
 isar_version: &isar_version 3.1.0+1
 
 environment:

server/immich-openapi-specs.json

@@ -6188,7 +6188,7 @@
   "info": {
     "title": "Immich",
     "description": "Immich API",
-    "version": "1.91.1",
+    "version": "1.91.3",
     "contact": {}
   },
   "tags": [],

server/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "immich",
-  "version": "1.91.1",
+  "version": "1.91.3",
   "lockfileVersion": 2,
   "requires": true,
   "packages": {
     "": {
       "name": "immich",
-      "version": "1.91.1",
+      "version": "1.91.3",
       "license": "UNLICENSED",
       "dependencies": {
         "@babel/runtime": "^7.22.11",

server/package.json

@@ -1,6 +1,6 @@
 {
   "name": "immich",
-  "version": "1.91.1",
+  "version": "1.91.3",
   "description": "",
   "author": "",
   "private": true,

server/src/infra/entities/system-config.entity.ts

@@ -37,7 +37,7 @@ export enum SystemConfigKey {
   JOB_VIDEO_CONVERSION_CONCURRENCY = 'job.videoConversion.concurrency',
   JOB_OBJECT_TAGGING_CONCURRENCY = 'job.objectTagging.concurrency',
   JOB_RECOGNIZE_FACES_CONCURRENCY = 'job.recognizeFaces.concurrency',
-  JOB_CLIP_ENCODING_CONCURRENCY = 'job.clipEncoding.concurrency',
+  JOB_CLIP_ENCODING_CONCURRENCY = 'job.smartSearch.concurrency',
   JOB_BACKGROUND_TASK_CONCURRENCY = 'job.backgroundTask.concurrency',
   JOB_STORAGE_TEMPLATE_MIGRATION_CONCURRENCY = 'job.storageTemplateMigration.concurrency',
   JOB_SEARCH_CONCURRENCY = 'job.search.concurrency',

server/src/infra/migrations/1700713871511-UsePgVectors.ts

@@ -1,3 +1,4 @@
+import { getCLIPModelInfo } from '@app/domain/smart-info/smart-info.constant';
 import { MigrationInterface, QueryRunner } from 'typeorm';
 
 export class UsePgVectors1700713871511 implements MigrationInterface {
@@ -8,13 +9,11 @@ export class UsePgVectors1700713871511 implements MigrationInterface {
         SELECT CARDINALITY(embedding::real[]) as dimsize
         FROM asset_faces
         LIMIT 1`);
-    const clipDimQuery = await queryRunner.query(`
-        SELECT CARDINALITY("clipEmbedding"::real[]) as dimsize
-        FROM smart_info
-        LIMIT 1`);
-
     const faceDimSize = faceDimQuery?.[0]?.['dimsize'] ?? 512;
-    const clipDimSize = clipDimQuery?.[0]?.['dimsize'] ?? 512;
+
+    const clipModelNameQuery = await queryRunner.query(`SELECT value FROM system_config WHERE key = 'machineLearning.clip.modelName'`);
+    const clipModelName: string = clipModelNameQuery?.[0]?.['value'] ?? 'ViT-B-32__openai';
+    const clipDimSize = getCLIPModelInfo(clipModelName.replace(/"/g, '')).dimSize;
 
     await queryRunner.query('CREATE EXTENSION IF NOT EXISTS vectors');
 
@@ -32,7 +31,9 @@ export class UsePgVectors1700713871511 implements MigrationInterface {
         INSERT INTO smart_search("assetId", embedding)
         SELECT si."assetId", si."clipEmbedding"
         FROM smart_info si
-        WHERE "clipEmbedding" IS NOT NULL`);
+        WHERE "clipEmbedding" IS NOT NULL
+        AND CARDINALITY("clipEmbedding"::real[]) = ${clipDimSize}
+        AND array_position(si."clipEmbedding", NULL) IS NULL`);
 
     await queryRunner.query(`ALTER TABLE smart_info DROP COLUMN IF EXISTS "clipEmbedding"`);
     }

web/src/api/open-api/api.ts

@@ -4,7 +4,7 @@
  * Immich
  * Immich API
  *
- * The version of the OpenAPI document: 1.91.1
+ * The version of the OpenAPI document: 1.91.3
  * 
  *
  * NOTE: This class is auto generated by OpenAPI Generator (https://openapi-generator.tech).

web/src/api/open-api/base.ts

@@ -4,7 +4,7 @@
  * Immich
  * Immich API
  *
- * The version of the OpenAPI document: 1.91.1
+ * The version of the OpenAPI document: 1.91.3
  * 
  *
  * NOTE: This class is auto generated by OpenAPI Generator (https://openapi-generator.tech).

web/src/api/open-api/common.ts

@@ -4,7 +4,7 @@
  * Immich
  * Immich API
  *
- * The version of the OpenAPI document: 1.91.1
+ * The version of the OpenAPI document: 1.91.3
  * 
  *
  * NOTE: This class is auto generated by OpenAPI Generator (https://openapi-generator.tech).

web/src/api/open-api/configuration.ts

@@ -4,7 +4,7 @@
  * Immich
  * Immich API
  *
- * The version of the OpenAPI document: 1.91.1
+ * The version of the OpenAPI document: 1.91.3
  * 
  *
  * NOTE: This class is auto generated by OpenAPI Generator (https://openapi-generator.tech).

web/src/api/open-api/index.ts

@@ -4,7 +4,7 @@
  * Immich
  * Immich API
  *
- * The version of the OpenAPI document: 1.91.1
+ * The version of the OpenAPI document: 1.91.3
  * 
  *
  * NOTE: This class is auto generated by OpenAPI Generator (https://openapi-generator.tech).

web/src/lib/assets/location-pin.svg

@@ -0,0 +1 @@
+<svg fill="#2443c2" version="1.1" id="Capa_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="101px" height="101px" viewBox="0 0 425.963 425.963" xml:space="preserve" stroke="#2443c2"><g id="SVGRepo_bgCarrier" stroke-width="0"></g><g id="SVGRepo_tracerCarrier" stroke-linecap="round" stroke-linejoin="round"></g><g id="SVGRepo_iconCarrier"> <g> <path d="M213.285,0h-0.608C139.114,0,79.268,59.826,79.268,133.361c0,48.202,21.952,111.817,65.246,189.081 c32.098,57.281,64.646,101.152,64.972,101.588c0.906,1.217,2.334,1.934,3.847,1.934c0.043,0,0.087,0,0.13-0.002 c1.561-0.043,3.002-0.842,3.868-2.143c0.321-0.486,32.637-49.287,64.517-108.976c43.03-80.563,64.848-141.624,64.848-181.482 C346.693,59.825,286.846,0,213.285,0z M274.865,136.62c0,34.124-27.761,61.884-61.885,61.884 c-34.123,0-61.884-27.761-61.884-61.884s27.761-61.884,61.884-61.884C247.104,74.736,274.865,102.497,274.865,136.62z"></path> </g> </g></svg>

web/src/lib/components/admin-page/settings/new-version-check-settings/new-version-check-settings.svelte

@@ -12,6 +12,7 @@
   import type { ResetOptions } from '$lib/utils/dipatch';
 
   export let newVersionCheckConfig: SystemConfigNewVersionCheckDto; // this is the config that is being edited
+  export let disabled = false;
 
   let savedConfig: SystemConfigNewVersionCheckDto;
   let defaultConfig: SystemConfigNewVersionCheckDto;
@@ -86,11 +87,13 @@
               title="ENABLED"
               subtitle="Enable period requests to GitHub to check for new releases"
               bind:checked={newVersionCheckConfig.enabled}
+              {disabled}
             />
             <SettingButtonsRow
               on:reset={({ detail }) => handleReset(detail)}
               on:save={saveSetting}
               showResetToDefault={!isEqual(savedConfig, defaultConfig)}
+              {disabled}
             />
           </div>
         </div>

web/src/lib/components/admin-page/settings/setting-switch.svelte

@@ -42,16 +42,15 @@
     />
 
     {#if disabled}
-      <span class="slider-disable cursor-not-allowed" />
+      <span class="slider slider-disabled cursor-not-allowed" />
     {:else}
-      <span class="slider cursor-pointer" />
+      <span class="slider slider-enabled cursor-pointer" />
     {/if}
   </label>
 </div>
 
 <style>
-  .slider,
-  .slider-disable {
+  .slider {
     position: absolute;
     top: 0;
     left: 0;
@@ -67,8 +66,7 @@
     cursor: not-allowed;
   }
 
-  .slider:before,
-  .slider-disable:before {
+  .slider:before {
     position: absolute;
     content: '';
     height: 20px;
@@ -82,18 +80,18 @@
     border-radius: 50%;
   }
 
-  input:checked + .slider-disable {
-    background-color: gray;
-  }
-
-  input:checked + .slider {
-    background-color: #adcbfa;
-  }
-
   input:checked + .slider:before {
     -webkit-transform: translateX(18px);
     -ms-transform: translateX(18px);
     transform: translateX(18px);
     background-color: #4250af;
   }
+
+  input:checked + .slider-disabled {
+    background-color: gray;
+  }
+
+  input:checked + .slider-enabled {
+    background-color: #adcbfa;
+  }
 </style>

web/src/lib/components/asset-viewer/detail-panel.svelte

@@ -569,7 +569,13 @@
 
 {#if latlng && $featureFlags.loaded && $featureFlags.map}
   <div class="h-[360px]">
-    <Map mapMarkers={[{ lat: latlng.lat, lon: latlng.lng, id: asset.id }]} center={latlng} zoom={14} simplified>
+    <Map
+      mapMarkers={[{ lat: latlng.lat, lon: latlng.lng, id: asset.id }]}
+      center={latlng}
+      zoom={15}
+      simplified
+      useLocationPin
+    >
       <svelte:fragment slot="popup" let:marker>
         {@const { lat, lon } = marker}
         <div class="flex flex-col items-center gap-1">

web/src/lib/components/shared-components/map/map.svelte

@@ -20,7 +20,7 @@
   import type { GeoJSONSource, LngLatLike, StyleSpecification } from 'maplibre-gl';
   import type { Feature, Geometry, GeoJsonProperties, Point } from 'geojson';
   import Icon from '$lib/components/elements/icon.svelte';
-  import { mdiCog } from '@mdi/js';
+  import { mdiCog, mdiMapMarker } from '@mdi/js';
   import { createEventDispatcher } from 'svelte';
 
   export let mapMarkers: MapMarkerResponseDto[];
@@ -29,6 +29,7 @@
   export let center: LngLatLike | undefined = undefined;
   export let simplified = false;
   export let clickable = false;
+  export let useLocationPin = false;
 
   let map: maplibregl.Map;
   let marker: maplibregl.Marker | null = null;
@@ -165,11 +166,16 @@
           $$slots.popup || handleAssetClick(event.detail.feature.properties.id, map);
         }}
       >
-        <img
-          src={api.getAssetThumbnailUrl(feature.properties?.id)}
-          class="rounded-full w-[60px] h-[60px] border-2 border-immich-primary shadow-lg hover:border-immich-dark-primary transition-all duration-200 hover:scale-150 object-contain bg-immich-primary"
-          alt={`Image with id ${feature.properties?.id}`}
-        />
+        {#if useLocationPin}
+          <Icon path={mdiMapMarker} size="60px" class="dark:text-immich-dark-primary text-immich-primary" />
+        {:else}
+          <img
+            src={api.getAssetThumbnailUrl(feature.properties?.id)}
+            class="rounded-full w-[60px] h-[60px] border-2 border-immich-primary shadow-lg hover:border-immich-dark-primary transition-all duration-200 hover:scale-150 object-cover bg-immich-primary"
+            alt={`Image with id ${feature.properties?.id}`}
+          />
+        {/if}
+
         {#if $$slots.popup}
           <Popup openOn="click" closeOnClickOutside>
             <slot name="popup" marker={asMarker(feature)} />

web/src/routes/admin/system-settings/+page.svelte

@@ -116,7 +116,7 @@
       </SettingAccordion>
 
       <SettingAccordion title="Version Check" subtitle="Enable/disable the new version notification">
-        <NewVersionCheckSettings newVersionCheckConfig={configs.newVersionCheck} />
+        <NewVersionCheckSettings disabled={$featureFlags.configFile} newVersionCheckConfig={configs.newVersionCheck} />
       </SettingAccordion>
 
       <SettingAccordion